New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: delete unused definition in README.md #17108

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@vsemozhetbyt
Member

vsemozhetbyt commented Nov 17, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, meta

Please, fast track, as it fails linter CI

@vsemozhetbyt vsemozhetbyt referenced this pull request Nov 17, 2017

Closed

doc: add Support section in README #16533

2 of 4 tasks complete
@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@refack

refack approved these changes Nov 17, 2017

+1 fast-track

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt Nov 17, 2017

Member

Do we have to wait for the complete CI or do node-test-linter and node-test-commit-linuxone suffice?

Member

vsemozhetbyt commented Nov 17, 2017

Do we have to wait for the complete CI or do node-test-linter and node-test-commit-linuxone suffice?

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Nov 17, 2017

Member

IMHO linter is enough, as this obviously does not touch code.

Member

refack commented Nov 17, 2017

IMHO linter is enough, as this obviously does not touch code.

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt Nov 17, 2017

Member

Landed in ca3f9b7
Thanks!

Member

vsemozhetbyt commented Nov 17, 2017

Landed in ca3f9b7
Thanks!

vsemozhetbyt added a commit that referenced this pull request Nov 17, 2017

doc: delete unused definition in README.md
PR-URL: #17108
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-del-unused-definition branch Nov 17, 2017

@vsemozhetbyt vsemozhetbyt referenced this pull request Nov 17, 2017

Closed

doc: fix a link in dgram.md #17107

3 of 3 tasks complete
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 17, 2017

Member

🎉 Thanks!

Member

Trott commented Nov 17, 2017

🎉 Thanks!

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: delete unused definition in README.md
PR-URL: #17108
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

MylesBorins added a commit that referenced this pull request Dec 19, 2017

doc: delete unused definition in README.md
PR-URL: #17108
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

gibfahn added a commit that referenced this pull request Dec 19, 2017

doc: delete unused definition in README.md
PR-URL: #17108
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: delete unused definition in README.md
PR-URL: #17108
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment