New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use better terminology for build machines #17142

Closed
wants to merge 1 commit into
base: master
from

Conversation

@addaleax
Member

addaleax commented Nov 19, 2017

R=@nodejs/release

@refack

refack approved these changes Nov 20, 2017

@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment
@gireeshpunathil

gireeshpunathil Nov 20, 2017

Member

I remember reviews that discouraged personal pronouns in documents. While none is introduced newly here, there are a few, please have another look and see if this is something you can workaround, while we are here.

Member

gireeshpunathil commented Nov 20, 2017

I remember reviews that discouraged personal pronouns in documents. While none is introduced newly here, there are a few, please have another look and see if this is something you can workaround, while we are here.

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Nov 20, 2017

Member

While none is introduced newly here, there are a few, please

doc/releases.md is entirely addressed to the releaser, so I'm not sure you is avoidable here. It basically goes through the 100 things a releaser has to do. Changing it would be a pretty substantial rewrite, and probably best done in a separate PR if at all.

As this isn't external documentation, I'm not sure removing you is actually necessary.

Member

gibfahn commented Nov 20, 2017

While none is introduced newly here, there are a few, please

doc/releases.md is entirely addressed to the releaser, so I'm not sure you is avoidable here. It basically goes through the 100 things a releaser has to do. Changing it would be a pretty substantial rewrite, and probably best done in a separate PR if at all.

As this isn't external documentation, I'm not sure removing you is actually necessary.

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt Nov 20, 2017

Member

FWIW, our STYLE_GUIDE.md notes:

Pronouns are acceptable in more colloquial documentation, like guides.

Member

vsemozhetbyt commented Nov 20, 2017

FWIW, our STYLE_GUIDE.md notes:

Pronouns are acceptable in more colloquial documentation, like guides.

@Trott

Trott approved these changes Nov 21, 2017

@mhdawson

LGTM

@mhdawson

This comment has been minimized.

Show comment
Hide comment
Member

mhdawson commented Nov 21, 2017

jasnell added a commit that referenced this pull request Nov 22, 2017

doc: use better terminology for build machines
PR-URL: #17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Nov 22, 2017

Member

Landed in 8f50407

Member

jasnell commented Nov 22, 2017

Landed in 8f50407

@jasnell jasnell closed this Nov 22, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 23, 2017

Member

There's one more instance in a comment in tools/release.sh if someone wants to fix that one or maybe hand it out as a good first task to someone.

Member

Trott commented Nov 23, 2017

There's one more instance in a comment in tools/release.sh if someone wants to fix that one or maybe hand it out as a good first task to someone.

@addaleax addaleax removed the author ready label Nov 28, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: use better terminology for build machines
PR-URL: #17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: use better terminology for build machines
PR-URL: #17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 19, 2017

doc: use better terminology for build machines
PR-URL: #17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Dec 19, 2017

doc: use better terminology for build machines
PR-URL: #17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: use better terminology for build machines
PR-URL: #17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

doc: use better terminology for build machines
PR-URL: nodejs#17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

doc: use better terminology for build machines
PR-URL: nodejs#17142
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment