New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: wrap callback in common.mustCall #17173

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@suman-mitra
Contributor

suman-mitra commented Nov 21, 2017

Adding common.mustCall to wrap the callback

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

My first contribution to node

@mscdex mscdex added the cluster label Nov 21, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Nov 21, 2017

Member

This shouldn't need to wait the 48 hours to land once CI passes

Member

jasnell commented Nov 21, 2017

This shouldn't need to wait the 48 hours to land once CI passes

@jasnell

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott approved these changes Nov 21, 2017

jasnell added a commit that referenced this pull request Nov 21, 2017

test: wrap callback in common.mustCall
PR-URL: #17173
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Nov 21, 2017

Member

Landed in a95d88c. Thank you and congrats on your first PR to core!

Member

jasnell commented Nov 21, 2017

Landed in a95d88c. Thank you and congrats on your first PR to core!

@jasnell jasnell closed this Nov 21, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: wrap callback in common.mustCall
PR-URL: #17173
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

MylesBorins added a commit that referenced this pull request Dec 19, 2017

test: wrap callback in common.mustCall
PR-URL: #17173
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

test: wrap callback in common.mustCall
PR-URL: #17173
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: wrap callback in common.mustCall
PR-URL: #17173
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: wrap callback in common.mustCall
PR-URL: nodejs#17173
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment