New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use common.throwOnUnhandledRejection #17218

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@esbb48
Contributor

esbb48 commented Nov 22, 2017

Add common.crashOnUnhandledRejection to test/parallel/test-http-agent.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

No

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Nov 22, 2017

Member

hey @esbb48 can you please change your commit message to

test: use common.crashOnUnhandledRejection

sorry about the confusion

edit:

you can do this with git commit --amend

Member

MylesBorins commented Nov 22, 2017

hey @esbb48 can you please change your commit message to

test: use common.crashOnUnhandledRejection

sorry about the confusion

edit:

you can do this with git commit --amend

@esbb48

This comment has been minimized.

Show comment
Hide comment
@esbb48

esbb48 Nov 22, 2017

Contributor

hi @MylesBorins

Thank your reply.

I already renamed my PR.

please check again.

Thanks!

Contributor

esbb48 commented Nov 22, 2017

hi @MylesBorins

Thank your reply.

I already renamed my PR.

please check again.

Thanks!

@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment

@mscdex mscdex added the http label Nov 22, 2017

jasnell added a commit that referenced this pull request Nov 22, 2017

test: use common.crashOnUnhandledRejection
PR-URL: #17218
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Nov 22, 2017

Member

Landed inn 339e247! Thank you and congrats on your PR to core!

Member

jasnell commented Nov 22, 2017

Landed inn 339e247! Thank you and congrats on your PR to core!

@jasnell jasnell closed this Nov 22, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use common.crashOnUnhandledRejection
PR-URL: #17218
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use common.crashOnUnhandledRejection
PR-URL: #17218
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

MylesBorins added a commit that referenced this pull request Dec 19, 2017

test: use common.crashOnUnhandledRejection
PR-URL: #17218
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

test: use common.crashOnUnhandledRejection
PR-URL: #17218
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use common.crashOnUnhandledRejection
PR-URL: #17218
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: use common.crashOnUnhandledRejection
PR-URL: nodejs#17218
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: use common.crashOnUnhandledRejection
PR-URL: nodejs#17218
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment