New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add common.crashOnHandleRejection #17225

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@Jackyen
Contributor

Jackyen commented Nov 22, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Nov 22, 2017

Member

hey @Jackyen it looks like you have a spelling error in the commit message, would you be able to replace commom with common

Member

MylesBorins commented Nov 22, 2017

hey @Jackyen it looks like you have a spelling error in the commit message, would you be able to replace commom with common

@Jackyen Jackyen changed the title from test: add commom.crashOnHandleRejection to test: add common.crashOnHandleRejection Nov 22, 2017

@mscdex mscdex added the net label Nov 22, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment

jasnell added a commit that referenced this pull request Nov 23, 2017

test: add common.crashOnHandleRejection
PR-URL: #17225
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Nov 23, 2017

Member

Landed in 6b56be2! Thank you and congrats on the PR to core!

Member

jasnell commented Nov 23, 2017

Landed in 6b56be2! Thank you and congrats on the PR to core!

@jasnell jasnell closed this Nov 23, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: add common.crashOnHandleRejection
PR-URL: #17225
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: add common.crashOnHandleRejection
PR-URL: #17225
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

MylesBorins added a commit that referenced this pull request Dec 19, 2017

test: add common.crashOnHandleRejection
PR-URL: #17225
Reviewed-By: James M Snell <jasnell@gmail.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

test: add common.crashOnHandleRejection
PR-URL: #17225
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: add common.crashOnHandleRejection
PR-URL: #17225
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: add common.crashOnHandleRejection
PR-URL: nodejs#17225
Reviewed-By: James M Snell <jasnell@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: add common.crashOnHandleRejection
PR-URL: nodejs#17225
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment