New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use common.crashOnUnhandledRejection #17233

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@shiningjason
Contributor

shiningjason commented Nov 22, 2017

add common.crashOnUnhandledRejection() to test/parallel/test-repl-load-multiline.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment
@gireeshpunathil

gireeshpunathil Nov 22, 2017

Member

@MylesBorins - are these code&learn?

Member

gireeshpunathil commented Nov 22, 2017

@MylesBorins - are these code&learn?

@jasnell

LGTM with @MylesBorins' comment addressed (which can be done on landing fwiw)

@jasnell

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

LGTM now

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Nov 23, 2017

Member

Landed in 317f596

Member

MylesBorins commented Nov 23, 2017

Landed in 317f596

MylesBorins added a commit that referenced this pull request Nov 23, 2017

test: use common.crashOnUnhandledRejection
PR-URL: #17233
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use common.crashOnUnhandledRejection
PR-URL: #17233
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use common.crashOnUnhandledRejection
PR-URL: #17233
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 19, 2017

test: use common.crashOnUnhandledRejection
PR-URL: #17233
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

test: use common.crashOnUnhandledRejection
PR-URL: #17233
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

test: use common.crashOnUnhandledRejection
PR-URL: #17233
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use common.crashOnUnhandledRejection
PR-URL: #17233
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: use common.crashOnUnhandledRejection
PR-URL: nodejs#17233
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: use common.crashOnUnhandledRejection
PR-URL: nodejs#17233
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment