New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use common.crashOnUnhandledRejection #17235

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@Kcin1993
Contributor

Kcin1993 commented Nov 22, 2017

Add common.crashOnUnhandledRejection to test/parallel/test-microtask-queue-run-immediate-domain.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
test: use common.crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to path: test/parallel/test-microtask-queue-run-immediate-domain.js
@MylesBorins

LGTM

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Nov 26, 2017

Member

landed in e4f5c63

Made slight tweak to commit message

Member

MylesBorins commented Nov 26, 2017

landed in e4f5c63

Made slight tweak to commit message

MylesBorins added a commit that referenced this pull request Nov 26, 2017

test: use common.crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: #17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Nov 26, 2017

Member

@maclover7 another one where the linter wasn't run but issue is reported as green

Member

MylesBorins commented Nov 26, 2017

@maclover7 another one where the linter wasn't run but issue is reported as green

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use common.crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: #17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use common.crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: #17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 19, 2017

test: use common.crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: #17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

test: use common.crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: #17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use common.crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: #17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: use common.crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: nodejs#17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: use common.crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to path:
  - test/parallel/test-microtask-queue-run-immediate-domain.js

PR-URL: nodejs#17235
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment