New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add common.crashOnUnhandledRejection() in test.js #17247

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@IHsuan
Contributor

IHsuan commented Nov 22, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Nov 22, 2017

Member

The change to tools/doc/node_modules/js-yaml/index.js will need to be dropped from this PR. It's an errant change caused by the make lint process that recently just started appearing.

Member

jasnell commented Nov 22, 2017

The change to tools/doc/node_modules/js-yaml/index.js will need to be dropped from this PR. It's an errant change caused by the make lint process that recently just started appearing.

@maclover7

LGTM if changes to tools/doc/node_modules/js-yaml/index.js are removed

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Nov 26, 2017

Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11712/

commit message needs to be updated as well

Member

MylesBorins commented Nov 26, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11712/

commit message needs to be updated as well

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Dec 6, 2017

Member

landed in 694e7ba

edit: I took the liberty to fix the meta data while landing

Member

MylesBorins commented Dec 6, 2017

landed in 694e7ba

edit: I took the liberty to fix the meta data while landing

@MylesBorins MylesBorins closed this Dec 6, 2017

MylesBorins added a commit that referenced this pull request Dec 6, 2017

test: add common.crashOnUnhandledRejection()
PR-URL: #17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: add common.crashOnUnhandledRejection()
PR-URL: #17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: add common.crashOnUnhandledRejection()
PR-URL: #17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: add common.crashOnUnhandledRejection()
PR-URL: #17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: add common.crashOnUnhandledRejection()
PR-URL: #17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: add common.crashOnUnhandledRejection()
PR-URL: #17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: add common.crashOnUnhandledRejection()
PR-URL: nodejs#17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: add common.crashOnUnhandledRejection()
PR-URL: nodejs#17247
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment