New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix linting error #17251

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@jasnell
Member

jasnell commented Nov 22, 2017

571ecd1 landing with a make lint error. This is necessary to fix it. We should fast track to unbreak master.

/cc @lance

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

jasnell referenced this pull request Nov 22, 2017

test: use arrow function instead of bind
Using an arrow function here eliminates the need to call `bind()`.

PR-URL: #17202
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
Member

jasnell commented Nov 22, 2017

jasnell added a commit that referenced this pull request Nov 22, 2017

test: fix linting error
Fast-tracked on landing to unbreak CI

PR-URL: #17251
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Nov 22, 2017

Member

Landed in cf5ad75

Member

jasnell commented Nov 22, 2017

Landed in cf5ad75

@jasnell jasnell closed this Nov 22, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: fix linting error
Fast-tracked on landing to unbreak CI

PR-URL: #17251
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: fix linting error
Fast-tracked on landing to unbreak CI

PR-URL: #17251
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 19, 2017

test: fix linting error
Fast-tracked on landing to unbreak CI

PR-URL: #17251
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 19, 2017

test: fix linting error
Fast-tracked on landing to unbreak CI

PR-URL: #17251
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: fix linting error
Fast-tracked on landing to unbreak CI

PR-URL: #17251
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: fix linting error
Fast-tracked on landing to unbreak CI

PR-URL: nodejs#17251
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: fix linting error
Fast-tracked on landing to unbreak CI

PR-URL: nodejs#17251
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment