Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x backport] build: remove cctest extension #17258

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@yhwang
Copy link
Member

commented Nov 22, 2017

cctest has so.59 extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang yh.wang@ibm.com

Original PR-URL: #16680
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Gibson Fahnestock gibfahn@gmail.com
Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com
Reviewed-By: Daniel Bevenius daniel.bevenius@gmail.com
Reviewed-By: Refael Ackermann refack@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
@gibfahn

This comment has been minimized.

@gibfahn gibfahn self-assigned this Nov 22, 2017

@yhwang

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2017

Aborted by Myles Borins, does this need a new CI?

@yhwang

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2017

@gibfahn Can you run a new CI for this PR? Thanks.

@gibfahn

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

@yhwang

This comment has been minimized.

Copy link
Member Author

commented Nov 30, 2017

@gibfahn the results are:

  • some raspberry tasks failed
  • test/linux-openssl110 should finish and the log says: Not valid for Node versions less than 9

@MylesBorins MylesBorins force-pushed the nodejs:v8.x-staging branch from 468562c to b05ef97 Dec 7, 2017

@gibfahn

This comment has been minimized.

Copy link
Member

commented Dec 19, 2017

@gibfahn

This comment has been minimized.

Copy link
Member

commented Dec 19, 2017

@yhwang could you rebase, I just landed an older PR that makes this conflict.

@gibfahn gibfahn force-pushed the nodejs:v8.x-staging branch 3 times, most recently from 563f1f6 to 6fa51d6 Dec 19, 2017

build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #16680
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@yhwang yhwang force-pushed the yhwang:backport-16680-to-v8.x branch from c379f5e to 3c88538 Dec 20, 2017

gibfahn added a commit that referenced this pull request Dec 20, 2017

build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #16680
Backport-PR-URL: #17258
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@gibfahn

This comment has been minimized.

Copy link
Member

commented Dec 20, 2017

Thanks, landed in 5174d25

@gibfahn gibfahn closed this Dec 20, 2017

@yhwang yhwang deleted the yhwang:backport-16680-to-v8.x branch Dec 20, 2017

gibfahn added a commit that referenced this pull request Jan 3, 2018

build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #16680
Backport-PR-URL: #17258
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.