New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update HTTP -> HTTPS in CONTRIBUTING.md #17261

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@him2him2
Contributor

him2him2 commented Nov 22, 2017

URLs were updated to use HTTPS protocol in CONTRIBUTING.md

Checklist
Affected core subsystem(s)

docs

@MylesBorins

LGTM

nit: can you please include the subsystem in the commit message and
doc: Update HTTP -> HTTPS in...

Shouldn't have to wait 48 hours

doc: Update HTTP -> HTTPs in CONTRIBUTING.md
URLs were updated to use HTTPS protocol in CONTRIBUTING.md

@him2him2 him2him2 changed the title from Update HTTP -> HTTPS in CONTRIBUTING.md to doc: Update HTTP -> HTTPS in CONTRIBUTING.md Nov 23, 2017

@Trott

Trott approved these changes Nov 23, 2017

@lpinca

lpinca approved these changes Nov 23, 2017

apapirovski added a commit that referenced this pull request Nov 23, 2017

doc: update http URLs to https in CONTRIBUTING.md
PR-URL: #17261
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Nov 23, 2017

Member

Landed in de3bb8f

Congrats @him2him2 on becoming a Contributor! 🥇

Member

apapirovski commented Nov 23, 2017

Landed in de3bb8f

Congrats @him2him2 on becoming a Contributor! 🥇

@him2him2 him2him2 deleted the him2him2:_fix_CONTRIBUTING.md_HTTPS branch Nov 24, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: update http URLs to https in CONTRIBUTING.md
PR-URL: #17261
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: update http URLs to https in CONTRIBUTING.md
PR-URL: #17261
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 19, 2017

doc: update http URLs to https in CONTRIBUTING.md
PR-URL: #17261
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

doc: update http URLs to https in CONTRIBUTING.md
PR-URL: #17261
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: update http URLs to https in CONTRIBUTING.md
PR-URL: #17261
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

doc: update http URLs to https in CONTRIBUTING.md
PR-URL: nodejs#17261
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

doc: update http URLs to https in CONTRIBUTING.md
PR-URL: nodejs#17261
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment