New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test of transform #17303

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@kt3k
Contributor

kt3k commented Nov 26, 2017

This is part of Nodefest's Code and Learn nodejs/code-and-learn#72

I added a test case of Transform constructor. The constructor can work without new operator, but the behavior doesn't seem covered in current test cases according to the latest coverage report ( https://coverage.nodejs.org/coverage-3a4fe7791e1c2a1b/root/_stream_transform.js.html ).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: add test of transform
Add a test case of Transform constructor.
@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca approved these changes Nov 26, 2017

@targos

targos approved these changes Nov 26, 2017

landing...

targos added a commit that referenced this pull request Nov 26, 2017

test: add test of stream Transform
Add a test case of Transform constructor without new.

PR-URL: #17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos

This comment has been minimized.

Show comment
Hide comment
@targos

targos Nov 26, 2017

Member

Landed in 9de15de

Thank you for the contribution!

Member

targos commented Nov 26, 2017

Landed in 9de15de

Thank you for the contribution!

@targos targos closed this Nov 26, 2017

@kt3k kt3k deleted the kt3k:feature/add-transform-constructor branch Nov 26, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: add test of stream Transform
Add a test case of Transform constructor without new.

PR-URL: #17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: add test of stream Transform
Add a test case of Transform constructor without new.

PR-URL: #17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 19, 2017

test: add test of stream Transform
Add a test case of Transform constructor without new.

PR-URL: #17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

test: add test of stream Transform
Add a test case of Transform constructor without new.

PR-URL: #17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: add test of stream Transform
Add a test case of Transform constructor without new.

PR-URL: #17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: add test of stream Transform
Add a test case of Transform constructor without new.

PR-URL: nodejs#17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: add test of stream Transform
Add a test case of Transform constructor without new.

PR-URL: nodejs#17303
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment