New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow running configure from any directory #17321

Merged
merged 1 commit into from Dec 10, 2017

Conversation

@gibfahn
Member

gibfahn commented Nov 26, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Nov 26, 2017

Member

One thing: this should either chdir back to the original directory or should print a warning to the console that the directory was changed, just as a friendly heads up to the user.

Member

jasnell commented Nov 26, 2017

One thing: this should either chdir back to the original directory or should print a warning to the console that the directory was changed, just as a friendly heads up to the user.

@bnoordhuis

@jasnell Not necessary, the pwd is a per-process property.

(That's coincidentally why cd is always a shell built-in, you can't implement it as a separate binary.)

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Nov 26, 2017

Member

heh... oh bah, that's right ;-) ...

Member

jasnell commented Nov 26, 2017

heh... oh bah, that's right ;-) ...

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Nov 27, 2017

Member

@jasnell might have been thinking about batch files, or shell scripts.

Member

refack commented Nov 27, 2017

@jasnell might have been thinking about batch files, or shell scripts.

Show outdated Hide outdated configure Outdated
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Nov 27, 2017

Member

might have been thinking about batch files, or shell scripts.

I was :)

Member

jasnell commented Nov 27, 2017

might have been thinking about batch files, or shell scripts.

I was :)

@refack refack removed the author ready label Nov 28, 2017

@refack

refack approved these changes Nov 28, 2017

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Nov 28, 2017

Member

Okay, so AFAICT we don't need root_dir any more, so I've removed it. If you've already approved this PR please take another look, it's quite different now.

Member

gibfahn commented Nov 28, 2017

Okay, so AFAICT we don't need root_dir any more, so I've removed it. If you've already approved this PR please take another look, it's quite different now.

@refack

refack approved these changes Nov 28, 2017

nice

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Nov 28, 2017

Member

we don't need root_dir any more, so I've removed it

That's a great proof that if we figure out path idiosyncrasies in configure we can keep them from affecting the downstream process.

Member

refack commented Nov 28, 2017

we don't need root_dir any more, so I've removed it

That's a great proof that if we figure out path idiosyncrasies in configure we can keep them from affecting the downstream process.

Show outdated Hide outdated configure Outdated
@gibfahn

This comment has been minimized.

Show comment
Hide comment
Member

gibfahn commented Dec 10, 2017

build: allow running configure from any directory
PR-URL: #17321
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@gibfahn gibfahn merged commit b7ff3c0 into nodejs:master Dec 10, 2017

@gibfahn gibfahn deleted the gibfahn:configure-cd branch Dec 10, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

build: allow running configure from any directory
PR-URL: #17321
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

build: allow running configure from any directory
PR-URL: #17321
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

@addaleax addaleax removed the author ready label Dec 13, 2017

gibfahn added a commit that referenced this pull request Dec 20, 2017

build: allow running configure from any directory
PR-URL: #17321
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

gibfahn added a commit that referenced this pull request Dec 20, 2017

build: allow running configure from any directory
PR-URL: #17321
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

build: allow running configure from any directory
PR-URL: #17321
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

gibfahn added a commit that referenced this pull request Dec 20, 2017

build: allow running configure from any directory
PR-URL: #17321
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Jan 2, 2018

2018-01-02, Version 6.12.3 'Boron' (LTS)
Notable Changes:

* build:
  - configure can now be run from any directory (Gibson Fahnestock)
    #17321

PR-URL: #17776

MylesBorins added a commit that referenced this pull request Jan 2, 2018

2018-01-02, Version 6.12.3 'Boron' (LTS)
Notable Changes:

* build:
  - configure can now be run from any directory (Gibson Fahnestock)
    #17321

PR-URL: #17776

gibfahn added a commit that referenced this pull request Jan 2, 2018

2018-01-02 Node.js v8.9.4 'Carbon' (LTS) Release
PR-URL: #17774

Notable Changes:

* deps:
  * upgrade npm to 5.6.0 (Kat Marchán) [#17535](#17535)
* build:
  * configure can now be run from any directory (Gibson Fahnestock) [#17321](#17321)

gibfahn added a commit that referenced this pull request Jan 3, 2018

2018-01-02 Node.js v8.9.4 'Carbon' (LTS) Release
PR-URL: #17774

Notable Changes:

* deps:
  * upgrade npm to 5.6.0 (Kat Marchán) [#17535](#17535)
* build:
  * configure can now be run from any directory (Gibson Fahnestock) [#17321](#17321)

gibfahn added a commit that referenced this pull request Jan 3, 2018

2018-01-02 Node.js v8.9.4 'Carbon' (LTS) Release
PR-URL: #17774

Notable Changes:

* deps:
  * upgrade npm to 5.6.0 (Kat Marchán) [#17535](#17535)
* build:
  * configure can now be run from any directory (Gibson Fahnestock) [#17321](#17321)

gibfahn added a commit that referenced this pull request Jan 3, 2018

2018-01-02 Node.js v8.9.4 'Carbon' (LTS) Release
PR-URL: #17774

Notable Changes:

* deps:
  * upgrade npm to 5.6.0 (Kat Marchán) [#17535](#17535)
* build:
  * configure can now be run from any directory (Gibson Fahnestock) [#17321](#17321)

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

build: allow running configure from any directory
PR-URL: nodejs#17321
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

2018-01-02, Version 6.12.3 'Boron' (LTS)
Notable Changes:

* build:
  - configure can now be run from any directory (Gibson Fahnestock)
    nodejs#17321

PR-URL: nodejs#17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

2018-01-02 Node.js v8.9.4 'Carbon' (LTS) Release
PR-URL: nodejs#17774

Notable Changes:

* deps:
  * upgrade npm to 5.6.0 (Kat Marchán) [nodejs#17535](nodejs#17535)
* build:
  * configure can now be run from any directory (Gibson Fahnestock) [nodejs#17321](nodejs#17321)

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

build: allow running configure from any directory
PR-URL: nodejs#17321
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

2018-01-02, Version 6.12.3 'Boron' (LTS)
Notable Changes:

* build:
  - configure can now be run from any directory (Gibson Fahnestock)
    nodejs#17321

PR-URL: nodejs#17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

2018-01-02 Node.js v8.9.4 'Carbon' (LTS) Release
PR-URL: nodejs#17774

Notable Changes:

* deps:
  * upgrade npm to 5.6.0 (Kat Marchán) [nodejs#17535](nodejs#17535)
* build:
  * configure can now be run from any directory (Gibson Fahnestock) [nodejs#17321](nodejs#17321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment