New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update test-http-response-statuscode to use countdown timer #17327

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@daxlab
Member

daxlab commented Nov 26, 2017

Refs: #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@mscdex mscdex added the http label Nov 26, 2017

@apapirovski

This comment has been minimized.

Show comment
Hide comment

apapirovski added a commit that referenced this pull request Dec 8, 2017

test: use Countdown in http-response-statuscode
PR-URL: #17327
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Dec 8, 2017

Member

Landed in f3f66a8

Thanks for the contribution @daxlab!

Member

apapirovski commented Dec 8, 2017

Landed in f3f66a8

Thanks for the contribution @daxlab!

@apapirovski apapirovski closed this Dec 8, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use Countdown in http-response-statuscode
PR-URL: #17327
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use Countdown in http-response-statuscode
PR-URL: #17327
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

@addaleax addaleax removed the author ready label Dec 13, 2017

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use Countdown in http-response-statuscode
PR-URL: #17327
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use Countdown in http-response-statuscode
PR-URL: #17327
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use Countdown in http-response-statuscode
PR-URL: #17327
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: use Countdown in http-response-statuscode
PR-URL: nodejs#17327
Refs: nodejs#17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: use Countdown in http-response-statuscode
PR-URL: nodejs#17327
Refs: nodejs#17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment