New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: test cases in `test-http-status-reason-invalid-chars` to use countdown #17342

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@mithunsasidharan
Contributor

mithunsasidharan commented Nov 27, 2017

Refactored test-http-status-reason-invalid-chars file to use countdown as per issue #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@daxlab

daxlab approved these changes Nov 27, 2017

@mithunsasidharan mithunsasidharan changed the title from Refactored `test-http-status-reason-invalid-chars` file to use countdown to refactor: test cases in `test-http-status-reason-invalid-chars` to use countdown Nov 27, 2017

@mscdex mscdex added the http label Nov 27, 2017

@maclover7

This comment has been minimized.

Show comment
Hide comment
@mithunsasidharan

This comment has been minimized.

Show comment
Hide comment
@mithunsasidharan

mithunsasidharan Dec 3, 2017

Contributor

@apapirovski : Can you please run the CI for this too ?

Contributor

mithunsasidharan commented Dec 3, 2017

@apapirovski : Can you please run the CI for this too ?

@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Dec 3, 2017

Member

@mithunsasidharan looks like there's a CI from before that came back green other than known failures. This should be ready to land whenever someone gets a chance.

Member

apapirovski commented Dec 3, 2017

@mithunsasidharan looks like there's a CI from before that came back green other than known failures. This should be ready to land whenever someone gets a chance.

@mithunsasidharan

This comment has been minimized.

Show comment
Hide comment
@mithunsasidharan

mithunsasidharan Dec 3, 2017

Contributor

@apapirovski : Thank you !

Contributor

mithunsasidharan commented Dec 3, 2017

@apapirovski : Thank you !

@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7

maclover7 Dec 3, 2017

Member

Landing...

Member

maclover7 commented Dec 3, 2017

Landing...

@maclover7 maclover7 self-assigned this Dec 3, 2017

@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7

maclover7 Dec 3, 2017

Member

Thank you for your contribution, landed in 2afd4e7.
❤️ 💚 💙 💛 💜

Member

maclover7 commented Dec 3, 2017

Thank you for your contribution, landed in 2afd4e7.
❤️ 💚 💙 💛 💜

@maclover7 maclover7 closed this Dec 3, 2017

maclover7 added a commit that referenced this pull request Dec 3, 2017

test: update test-http-status-reason-invalid-chars to use countdown
PR-URL: #17342
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@mithunsasidharan mithunsasidharan deleted the mithunsasidharan:pr_4 branch Dec 3, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: update test-http-status-reason-invalid-chars to use countdown
PR-URL: #17342
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: update test-http-status-reason-invalid-chars to use countdown
PR-URL: #17342
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test-http-status-reason-invalid-chars to use countdown
PR-URL: #17342
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test-http-status-reason-invalid-chars to use countdown
PR-URL: #17342
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test-http-status-reason-invalid-chars to use countdown
PR-URL: #17342
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: update test-http-status-reason-invalid-chars to use countdown
PR-URL: nodejs#17342
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: update test-http-status-reason-invalid-chars to use countdown
PR-URL: nodejs#17342
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment