New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test/parallel/test-http-pipe-fs.js to use countdown #17346

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@chungngoops
Contributor

chungngoops commented Nov 27, 2017

-Refactor the test case test/parallel/test-http-pipe-fs.js to use countdown, as issues #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex mscdex added the http label Nov 27, 2017

Show outdated Hide outdated test/parallel/test-http-pipe-fs.js Outdated
@addaleax

Thanks, looks good!

@addaleax

This comment has been minimized.

Show comment
Hide comment
Member

addaleax commented Nov 30, 2017

@maclover7

This comment has been minimized.

Show comment
Hide comment
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Dec 1, 2017

Member

Landed in fa07249

Thanks for the PR! 🎉

Member

addaleax commented Dec 1, 2017

Landed in fa07249

Thanks for the PR! 🎉

@addaleax addaleax closed this Dec 1, 2017

addaleax added a commit that referenced this pull request Dec 1, 2017

test: update test/parallel/test-http-pipe-fs.js to use countdown
PR-URL: #17346
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@addaleax addaleax removed the author ready label Dec 1, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: update test/parallel/test-http-pipe-fs.js to use countdown
PR-URL: #17346
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: update test/parallel/test-http-pipe-fs.js to use countdown
PR-URL: #17346
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test/parallel/test-http-pipe-fs.js to use countdown
PR-URL: #17346
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test/parallel/test-http-pipe-fs.js to use countdown
PR-URL: #17346
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test/parallel/test-http-pipe-fs.js to use countdown
PR-URL: #17346
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test/parallel/test-http-pipe-fs.js to use countdown
PR-URL: #17346
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: update test/parallel/test-http-pipe-fs.js to use countdown
PR-URL: nodejs#17346
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: update test/parallel/test-http-pipe-fs.js to use countdown
PR-URL: nodejs#17346
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment