Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
http2: refactor close/destroy for Http2Stream and Http2Session #17406
This is a significant refactoring of the close/destroy flow and API for
There are several important bits:
There are still a few more todo's that need to be handled here. Specifically, proper handling of last stream ID on a goaway frame, but this is already a sizable chunk of work. Let's get this reviewed and landed and I'll keep pushing forward.
Affected core subsystem(s)
Trying again: https://ci.nodejs.org/job/node-test-pull-request/11895/
Very good progress, I hope I reviewed all of it. Let me know if I missed some critical changes.
@jasnell Can you give an overview over what’s going to happen with this PR? Is it (nearly) ready? :)
And maybe, are the C++ bits independent enough from the rest that they could be split off into their own PR? I’ll continue working on