New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: refactor close/destroy for Http2Stream and Http2Session #17406

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@jasnell
Member

jasnell commented Nov 30, 2017

This is a significant refactoring of the close/destroy flow and API for Http2Stream and Http2Session. There is quite a bit more to do in here, it's a bit slow going because the flow is rather complex and I'm trying not to break too much as I go.

There are several important bits:

  1. Previously, the destroy operations for both Http2Session and Http2Stream were executed over multiple nextTick and setImmediate hops. Now the objects are unusable immediately when calling destroy() and we're using env->SetImmediate() to handle the need to defer final cleanup (cc @addaleax)

  2. This reworks the destroy and error handling flow between the Http2Session and socket and eliminates the 'socketError' event. Errors occurring on the socket are forwarded to the error event on the associated Http2Session. On the server, those are forwarded to the 'sessionError' event.

  3. Http2Stream.prototype.rstStream() has been renamed to Http2Stream.prototype.close() and the various rstWith.... aliases have been removed.

  4. An improved Http2Session.prototype.close() has been implemented, allowing better API symmetry.

There are still a few more todo's that need to be handled here. Specifically, proper handling of last stream ID on a goaway frame, but this is already a sizable chunk of work. Let's get this reviewed and landed and I'll keep pushing forward.

/cc @nodejs/http2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@jasnell jasnell requested a review from mcollina Dec 4, 2017

@jasnell jasnell changed the title from [WIP] http2: refactor close/destroy for Http2Stream and Http2Session to http2: refactor close/destroy for Http2Stream and Http2Session Dec 4, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Dec 4, 2017

Member

Ping @nodejs/http2 ... this should be ready for review. It's a rather large and complicated set of changes that refactors the shutdown, destroy and cleanup logic in Http2Stream and Http2Session. It's not going to be trivial to review.

@mcollina ... Please take a good careful look at this.

Member

jasnell commented Dec 4, 2017

Ping @nodejs/http2 ... this should be ready for review. It's a rather large and complicated set of changes that refactors the shutdown, destroy and cleanup logic in Http2Stream and Http2Session. It's not going to be trivial to review.

@mcollina ... Please take a good careful look at this.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

This comment has been minimized.

Show comment
Hide comment
Member

jasnell commented Dec 5, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Dec 5, 2017

Member

Ok, there's definitely still quite a bit of wonkiness in here that I'll have to chase down.

Member

jasnell commented Dec 5, 2017

Ok, there's definitely still quite a bit of wonkiness in here that I'll have to chase down.

@jasnell

This comment has been minimized.

Show comment
Hide comment
Member

jasnell commented Dec 6, 2017

@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Dec 6, 2017

Member

I'll start reviewing this over the next few days. Might take a little while to get through. I would also like to run this against the test suite I have for express & related middleware.

Member

apapirovski commented Dec 6, 2017

I'll start reviewing this over the next few days. Might take a little while to get through. I would also like to run this against the test suite I have for express & related middleware.

@jasnell jasnell changed the title from http2: refactor close/destroy for Http2Stream and Http2Session to [WIP] http2: refactor close/destroy for Http2Stream and Http2Session Dec 6, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Dec 6, 2017

Member

@apapirovski ... @mcollina and I discussed this a bit today and worked through a few more changes that need to be made (which will actually undo some of the changes made in this PR so far...). I'm working on those now and should hopefully have it complete by end of the day tomorrow at the latest.

Member

jasnell commented Dec 6, 2017

@apapirovski ... @mcollina and I discussed this a bit today and worked through a few more changes that need to be made (which will actually undo some of the changes made in this PR so far...). I'm working on those now and should hopefully have it complete by end of the day tomorrow at the latest.

@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Dec 6, 2017

Member

@jasnell No worries. Keep me posted, happy to start reviewing whenever it's ready.

Member

apapirovski commented Dec 6, 2017

@jasnell No worries. Keep me posted, happy to start reviewing whenever it's ready.

@mcollina

Very good progress, I hope I reviewed all of it. Let me know if I missed some critical changes.

Show outdated Hide outdated lib/internal/http2/core.js Outdated
Show outdated Hide outdated lib/internal/http2/core.js Outdated
Show outdated Hide outdated lib/internal/http2/core.js Outdated
Show outdated Hide outdated lib/internal/http2/core.js Outdated
Show outdated Hide outdated lib/internal/http2/core.js Outdated
// case, drop the data on the floor. An error should have already been
// emitted.
if (this.destroyed)
return;

This comment has been minimized.

@mcollina

mcollina Dec 11, 2017

Member

this should not be needed, why it is?

@mcollina

mcollina Dec 11, 2017

Member

this should not be needed, why it is?

This comment has been minimized.

@jasnell

jasnell Dec 11, 2017

Member

same as above :-)

@jasnell

jasnell Dec 11, 2017

Member

same as above :-)

// the Http2Stream to be closed and ultimately destroyed. After calling
// close, it is still possible to queue up PRIORITY and RST_STREAM frames,
// but no DATA and HEADERS frames may be sent.
close(code = NGHTTP2_NO_ERROR, callback) {

This comment has been minimized.

@mcollina

mcollina Dec 11, 2017

Member

Can this be close(callback)? I would prefer to not expose NGHTTP2 error codes. For errors, we have destroy().

@mcollina

mcollina Dec 11, 2017

Member

Can this be close(callback)? I would prefer to not expose NGHTTP2 error codes. For errors, we have destroy().

This comment has been minimized.

@jasnell

jasnell Dec 11, 2017

Member

This is not an NGHTTP2 error code, it's an HTTP2 RST_STREAM error code. An RST_STREAM is used to close the stream here so we need to know what code to use. There are legitimate cases where the user might specify something other than NO_ERROR without using destroy(err)

@jasnell

jasnell Dec 11, 2017

Member

This is not an NGHTTP2 error code, it's an HTTP2 RST_STREAM error code. An RST_STREAM is used to close the stream here so we need to know what code to use. There are legitimate cases where the user might specify something other than NO_ERROR without using destroy(err)

Show outdated Hide outdated lib/internal/http2/core.js Outdated
Show outdated Hide outdated lib/internal/http2/core.js Outdated
Show outdated Hide outdated lib/internal/http2/core.js Outdated
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

This comment has been minimized.

Show comment
Hide comment
Member

jasnell commented Dec 12, 2017

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Dec 12, 2017

Member

@jasnell Can you give an overview over what’s going to happen with this PR? Is it (nearly) ready? :)

And maybe, are the C++ bits independent enough from the rest that they could be split off into their own PR? I’ll continue working on StreamBase after #17564 and I think that might be nice to have this landed before that…

Member

addaleax commented Dec 12, 2017

@jasnell Can you give an overview over what’s going to happen with this PR? Is it (nearly) ready? :)

And maybe, are the C++ bits independent enough from the rest that they could be split off into their own PR? I’ll continue working on StreamBase after #17564 and I think that might be nice to have this landed before that…

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Dec 12, 2017

Member

This pr is nearly there. Working on getting one final test working then will be squashing and reorganizing the commits down. Unfortunately, no, the c++ bits cannot be spun off into their own pr. The goal is to get this finished up today.

Member

jasnell commented Dec 12, 2017

This pr is nearly there. Working on getting one final test working then will be squashing and reorganizing the commits down. Unfortunately, no, the c++ bits cannot be spun off into their own pr. The goal is to get this finished up today.

Show outdated Hide outdated lib/internal/http2/compat.js Outdated
@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Dec 12, 2017

Member

Does this solve #16880 and #16752?

Member

mcollina commented Dec 12, 2017

Does this solve #16880 and #16752?

@jasnell

This comment has been minimized.

Show comment
Hide comment

@jasnell jasnell changed the title from [WIP] http2: refactor close/destroy for Http2Stream and Http2Session to http2: refactor close/destroy for Http2Stream and Http2Session Dec 12, 2017

@jasnell jasnell removed the in progress label Dec 12, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Dec 12, 2017

Member

@mcollina @nodejs/http2 ... this should be ready to go. CI is green

Member

jasnell commented Dec 12, 2017

@mcollina @nodejs/http2 ... this should be ready to go. CI is green

@jasnell jasnell referenced this pull request Dec 12, 2017

Closed

http2: implement ref() and unref() on sessions #17620

3 of 4 tasks complete
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Dec 12, 2017

Member

@mcollina ... yes, this should fix both of those issues.

Member

jasnell commented Dec 12, 2017

@mcollina ... yes, this should fix both of those issues.

Show outdated Hide outdated src/node_http2.cc Outdated
Show outdated Hide outdated src/node_http2.cc Outdated
Show outdated Hide outdated src/node_http2.cc Outdated
// Stop reading on the i/o stream
if (stream_ != nullptr)
stream_->ReadStop();

This comment has been minimized.

@addaleax

addaleax Dec 13, 2017

Member

Can you also clear the callbacks & call Unconsume, i.e. like in #17478?

@addaleax

addaleax Dec 13, 2017

Member

Can you also clear the callbacks & call Unconsume, i.e. like in #17478?

Show outdated Hide outdated src/node_http2.cc Outdated
// Note: if ssize_t is not defined (e.g. on Win32), nghttp2 will typedef
// ssize_t to int. Cast here so that the < 0 check actually works on
// Windows.
if (static_cast<int>(ret) < 0) {

This comment has been minimized.

@addaleax

addaleax Dec 13, 2017

Member

ditto

@addaleax

addaleax Dec 13, 2017

Member

ditto

Show outdated Hide outdated src/node_http2.cc Outdated
instance containing additional data to be carried within the GOAWAY frame.
Transmits a `GOAWAY` frame to the connected peer *without* shutting down the
`Http2Session`.

This comment has been minimized.

@addaleax

addaleax Dec 13, 2017

Member

What would be a use case for this? :)

@addaleax

addaleax Dec 13, 2017

Member

What would be a use case for this? :)

This comment has been minimized.

@jasnell

jasnell Dec 13, 2017

Member

Graceful shutdown. Sending opaqueData. Sending a specific last stream ID. Etc

@jasnell

jasnell Dec 13, 2017

Member

Graceful shutdown. Sending opaqueData. Sending a specific last stream ID. Etc

Show outdated Hide outdated lib/internal/http2/core.js Outdated
Show outdated Hide outdated lib/internal/http2/core.js Outdated
@jasnell

This comment has been minimized.

Show comment
Hide comment
Member

jasnell commented Dec 13, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell
Member

jasnell commented Dec 15, 2017

Ping @mcollina

MylesBorins added a commit to MylesBorins/node that referenced this pull request Apr 12, 2018

http2: be sure to destroy the Http2Stream
PR-URL: nodejs#17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins added a commit to MylesBorins/node that referenced this pull request Apr 12, 2018

http2: cleanup Http2Stream/Http2Session destroy
PR-URL: nodejs#17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This is a significant cleanup and refactoring of the
cleanup/close/destroy logic for Http2Stream and Http2Session.
There are significant changes here in the timing and ordering
of cleanup logic, JS apis. and various related necessary edits.

kjin added a commit to kjin/node that referenced this pull request Apr 28, 2018

http2: be sure to destroy the Http2Stream
PR-URL: nodejs#17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

Backport-PR-URL: nodejs#18050

kjin added a commit to kjin/node that referenced this pull request Apr 28, 2018

http2: cleanup Http2Stream/Http2Session destroy
Backport-PR-URL: nodejs#18050
PR-URL: nodejs#17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This is a significant cleanup and refactoring of the
cleanup/close/destroy logic for Http2Stream and Http2Session.
There are significant changes here in the timing and ordering
of cleanup logic, JS apis. and various related necessary edits.

kjin added a commit to kjin/node that referenced this pull request Apr 28, 2018

doc: update pushStream docs to use err first
Refs: nodejs#17406 (comment)

PR-URL: nodejs#18088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Apr 28, 2018

doc: fix documentation of http2Stream.pushstream()
Improve documentation of callback signature of
http2Stream.pushStream() function to align with
the changes made in nodejs#17406.

PR-URL: nodejs#18258
Fixes: nodejs#18198
Refs: nodejs#17406
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Apr 28, 2018

doc: update pushStream docs to use err first
Refs: nodejs#17406 (comment)

PR-URL: nodejs#18088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Apr 28, 2018

doc: fix documentation of http2Stream.pushstream()
Improve documentation of callback signature of
http2Stream.pushStream() function to align with
the changes made in nodejs#17406.

PR-URL: nodejs#18258
Fixes: nodejs#18198
Refs: nodejs#17406
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

kjin added a commit to kjin/node that referenced this pull request May 1, 2018

http2: be sure to destroy the Http2Stream
PR-URL: nodejs#17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

Backport-PR-URL: nodejs#18050

kjin added a commit to kjin/node that referenced this pull request May 1, 2018

http2: cleanup Http2Stream/Http2Session destroy
Backport-PR-URL: nodejs#18050
PR-URL: nodejs#17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This is a significant cleanup and refactoring of the
cleanup/close/destroy logic for Http2Stream and Http2Session.
There are significant changes here in the timing and ordering
of cleanup logic, JS apis. and various related necessary edits.

kjin added a commit to kjin/node that referenced this pull request May 1, 2018

doc: update pushStream docs to use err first
Refs: nodejs#17406 (comment)

PR-URL: nodejs#18088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

kjin added a commit to kjin/node that referenced this pull request May 1, 2018

doc: fix documentation of http2Stream.pushstream()
Improve documentation of callback signature of
http2Stream.pushStream() function to align with
the changes made in nodejs#17406.

PR-URL: nodejs#18258
Fixes: nodejs#18198
Refs: nodejs#17406
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request May 2, 2018

http2: be sure to destroy the Http2Stream
Backport-PR-URL: #20456
PR-URL: #17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

Backport-PR-URL: #18050

MylesBorins added a commit that referenced this pull request May 2, 2018

http2: cleanup Http2Stream/Http2Session destroy
Backport-PR-URL: #18050
Backport-PR-URL: #20456
PR-URL: #17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This is a significant cleanup and refactoring of the
cleanup/close/destroy logic for Http2Stream and Http2Session.
There are significant changes here in the timing and ordering
of cleanup logic, JS apis. and various related necessary edits.

MylesBorins added a commit that referenced this pull request May 2, 2018

doc: update pushStream docs to use err first
Refs: #17406 (comment)

Backport-PR-URL: #20456
PR-URL: #18088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

MylesBorins added a commit that referenced this pull request May 2, 2018

doc: fix documentation of http2Stream.pushstream()
Improve documentation of callback signature of
http2Stream.pushStream() function to align with
the changes made in #17406.

Backport-PR-URL: #20456
PR-URL: #18258
Fixes: #18198
Refs: #17406
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request May 2, 2018

Merged

v8.11.2 proposal #20478

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

doc: fix documentation of http2Stream.pushstream()
Improve documentation of callback signature of
http2Stream.pushStream() function to align with
the changes made in nodejs#17406.

PR-URL: nodejs#18258
Fixes: nodejs#18198
Refs: nodejs#17406
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

ChALkeR added a commit to ChALkeR/io.js that referenced this pull request Jun 23, 2018

doc: fix http2stream.pushStream error doc
The old error code `ERR_HTTP2_STREAM_CLOSED` was removed in commit
0babd18 (pull request nodejs#17406), and the
testcase for http2stream.pushStream was changed accordingly, but the
documentation change was overlooked.

This commit fixes it and aligns the documentation with the testcase.

This is a part of the fixes hinted by nodejs#21470, which includes some tests
for error codes usage and documentation and enforces a stricter format.

Refs: nodejs#21470
Refs: nodejs#17406

@ChALkeR ChALkeR referenced this pull request Jun 23, 2018

Merged

doc: fix http2stream.pushStream error doc #21487

3 of 4 tasks complete

ChALkeR added a commit to ChALkeR/io.js that referenced this pull request Jul 10, 2018

doc: fix http2stream.pushStream error doc
The old error code `ERR_HTTP2_STREAM_CLOSED` was removed in commit
0babd18 (pull request nodejs#17406), and the
testcase for http2stream.pushStream was changed accordingly, but the
documentation change was overlooked.

This commit fixes it and aligns the documentation with the testcase.

This is a part of the fixes hinted by nodejs#21470, which includes some tests
for error codes usage and documentation and enforces a stricter format.

Refs: nodejs#21470
Refs: nodejs#17406
PR-URL: nodejs#21487
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos added a commit that referenced this pull request Jul 12, 2018

doc: fix http2stream.pushStream error doc
The old error code `ERR_HTTP2_STREAM_CLOSED` was removed in commit
0babd18 (pull request #17406), and the
testcase for http2stream.pushStream was changed accordingly, but the
documentation change was overlooked.

This commit fixes it and aligns the documentation with the testcase.

This is a part of the fixes hinted by #21470, which includes some tests
for error codes usage and documentation and enforces a stricter format.

Refs: #21470
Refs: #17406
PR-URL: #21487
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Aug 23, 2018

doc: fix http2stream.pushStream error doc
The old error code `ERR_HTTP2_STREAM_CLOSED` was removed in commit
0babd18 (pull request nodejs#17406), and the
testcase for http2stream.pushStream was changed accordingly, but the
documentation change was overlooked.

This commit fixes it and aligns the documentation with the testcase.

This is a part of the fixes hinted by nodejs#21470, which includes some tests
for error codes usage and documentation and enforces a stricter format.

Refs: nodejs#21470
Refs: nodejs#17406
PR-URL: nodejs#21487
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Sep 17, 2018

doc: fix http2stream.pushStream error doc
The old error code `ERR_HTTP2_STREAM_CLOSED` was removed in commit
0babd18 (pull request nodejs#17406), and the
testcase for http2stream.pushStream was changed accordingly, but the
documentation change was overlooked.

This commit fixes it and aligns the documentation with the testcase.

This is a part of the fixes hinted by nodejs#21470, which includes some tests
for error codes usage and documentation and enforces a stricter format.

Refs: nodejs#21470
Refs: nodejs#17406
PR-URL: nodejs#21487
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Sep 19, 2018

doc: fix http2stream.pushStream error doc
The old error code `ERR_HTTP2_STREAM_CLOSED` was removed in commit
0babd18 (pull request nodejs#17406), and the
testcase for http2stream.pushStream was changed accordingly, but the
documentation change was overlooked.

This commit fixes it and aligns the documentation with the testcase.

This is a part of the fixes hinted by nodejs#21470, which includes some tests
for error codes usage and documentation and enforces a stricter format.

Refs: nodejs#21470
Refs: nodejs#17406
PR-URL: nodejs#21487
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Sep 25, 2018

doc: fix http2stream.pushStream error doc
The old error code `ERR_HTTP2_STREAM_CLOSED` was removed in commit
0babd18 (pull request nodejs#17406), and the
testcase for http2stream.pushStream was changed accordingly, but the
documentation change was overlooked.

This commit fixes it and aligns the documentation with the testcase.

This is a part of the fixes hinted by nodejs#21470, which includes some tests
for error codes usage and documentation and enforces a stricter format.

Refs: nodejs#21470
Refs: nodejs#17406
PR-URL: nodejs#21487
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Oct 16, 2018

doc: fix http2stream.pushStream error doc
The old error code `ERR_HTTP2_STREAM_CLOSED` was removed in commit
0babd18 (pull request nodejs#17406), and the
testcase for http2stream.pushStream was changed accordingly, but the
documentation change was overlooked.

This commit fixes it and aligns the documentation with the testcase.

This is a part of the fixes hinted by nodejs#21470, which includes some tests
for error codes usage and documentation and enforces a stricter format.

Refs: nodejs#21470
Refs: nodejs#17406
PR-URL: nodejs#21487
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

BethGriggs added a commit to BethGriggs/node that referenced this pull request Oct 16, 2018

doc: fix http2stream.pushStream error doc
The old error code `ERR_HTTP2_STREAM_CLOSED` was removed in commit
0babd18 (pull request nodejs#17406), and the
testcase for http2stream.pushStream was changed accordingly, but the
documentation change was overlooked.

This commit fixes it and aligns the documentation with the testcase.

This is a part of the fixes hinted by nodejs#21470, which includes some tests
for error codes usage and documentation and enforces a stricter format.

Refs: nodejs#21470
Refs: nodejs#17406
Backport-PR-URL: nodejs#22850
PR-URL: nodejs#21487
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

BethGriggs added a commit that referenced this pull request Oct 17, 2018

doc: fix http2stream.pushStream error doc
The old error code `ERR_HTTP2_STREAM_CLOSED` was removed in commit
0babd18 (pull request #17406), and the
testcase for http2stream.pushStream was changed accordingly, but the
documentation change was overlooked.

This commit fixes it and aligns the documentation with the testcase.

This is a part of the fixes hinted by #21470, which includes some tests
for error codes usage and documentation and enforces a stricter format.

Refs: #21470
Refs: #17406
Backport-PR-URL: #22850
PR-URL: #21487
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment