New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac: refactor test-http-response-multiheaders.js test to use countdown #17419

Closed
wants to merge 3 commits into
base: master
from

Conversation

@LEQADA
Contributor

LEQADA commented Dec 1, 2017

Refs #17169 to fix test/parallel/test-http-response-multiheaders.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdex mscdex added the http label Dec 2, 2017

@lpinca

lpinca approved these changes Dec 2, 2017

@LEQADA

This comment has been minimized.

Show comment
Hide comment
@LEQADA

LEQADA Dec 3, 2017

Contributor

Changed commit messages to have less than 72 chars.

Contributor

LEQADA commented Dec 3, 2017

Changed commit messages to have less than 72 chars.

@maclover7

One quick comment, then LGTM

Show outdated Hide outdated test/parallel/test-http-response-multiheaders.js Outdated
@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7

maclover7 Dec 5, 2017

Member

Landing...

Member

maclover7 commented Dec 5, 2017

Landing...

@maclover7 maclover7 self-assigned this Dec 5, 2017

@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7

maclover7 Dec 5, 2017

Member

Landed in 35c01d8, congrats on your first PR to Node.js!
❤️ 💚 💙 💛 💜

Member

maclover7 commented Dec 5, 2017

Landed in 35c01d8, congrats on your first PR to Node.js!
❤️ 💚 💙 💛 💜

@maclover7 maclover7 closed this Dec 5, 2017

maclover7 added a commit that referenced this pull request Dec 5, 2017

test: update test-http-response-multiheaders to use countdown
PR-URL: #17419
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@addaleax addaleax removed the author ready label Dec 7, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: update test-http-response-multiheaders to use countdown
PR-URL: #17419
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: update test-http-response-multiheaders to use countdown
PR-URL: #17419
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test-http-response-multiheaders to use countdown
PR-URL: #17419
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test-http-response-multiheaders to use countdown
PR-URL: #17419
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test-http-response-multiheaders to use countdown
PR-URL: #17419
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: update test-http-response-multiheaders to use countdown
PR-URL: nodejs#17419
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: update test-http-response-multiheaders to use countdown
PR-URL: nodejs#17419
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@LEQADA LEQADA deleted the LEQADA:use-countdown-test-http-response-multiheaders branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment