New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use Countdown in http test #17436

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@mithunsasidharan
Contributor

mithunsasidharan commented Dec 3, 2017

refactored test case in test-http-response-multi-content-length to use countdown as per issue #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex mscdex added the http label Dec 3, 2017

@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Dec 3, 2017

Member

Nit: the commit title should be adjusted to be < 50 characters.

Member

apapirovski commented Dec 3, 2017

Nit: the commit title should be adjusted to be < 50 characters.

@mithunsasidharan mithunsasidharan changed the title from test: refactored test case in `test-http-response-multi-content-length` to use countdown to test: refactored test-http-response-multi-content-length to use countdown Dec 3, 2017

@mithunsasidharan

This comment has been minimized.

Show comment
Hide comment
@mithunsasidharan

mithunsasidharan Dec 3, 2017

Contributor

@apapirovski : Update the commit message. Kindly review the PR now. Thanks !

Contributor

mithunsasidharan commented Dec 3, 2017

@apapirovski : Update the commit message. Kindly review the PR now. Thanks !

@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Dec 3, 2017

Member

The commit message still looks too long to me (70 chars or so). I would go with something like test: use Countdown in http test

Member

apapirovski commented Dec 3, 2017

The commit message still looks too long to me (70 chars or so). I would go with something like test: use Countdown in http test

@mithunsasidharan mithunsasidharan changed the title from test: refactored test-http-response-multi-content-length to use countdown to test: use Countdown in http test Dec 3, 2017

@mithunsasidharan

This comment has been minimized.

Show comment
Hide comment
@mithunsasidharan

mithunsasidharan Dec 3, 2017

Contributor

@apapirovski : I've updated the commit message. Kindly review the PR now. Thanks !

Contributor

mithunsasidharan commented Dec 3, 2017

@apapirovski : I've updated the commit message. Kindly review the PR now. Thanks !

@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Dec 3, 2017

Member

Looks good, thanks!

Member

apapirovski commented Dec 3, 2017

Looks good, thanks!

@lpinca

lpinca approved these changes Dec 4, 2017

@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Dec 5, 2017

Member

Landed in 90b257e, thank you!

Member

tniessen commented Dec 5, 2017

Landed in 90b257e, thank you!

@tniessen tniessen closed this Dec 5, 2017

tniessen added a commit that referenced this pull request Dec 5, 2017

test: use Countdown in http test
PR-URL: #17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use Countdown in http test
PR-URL: #17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use Countdown in http test
PR-URL: #17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use Countdown in http test
PR-URL: #17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use Countdown in http test
PR-URL: #17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use Countdown in http test
PR-URL: #17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: use Countdown in http test
PR-URL: nodejs#17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: use Countdown in http test
PR-URL: nodejs#17436
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment