New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor : test-http-request-dont-override-options to use common.mustCall #17438

Closed
wants to merge 1 commit into
base: master
from

Conversation

@mithunsasidharan
Contributor

mithunsasidharan commented Dec 3, 2017

refactor : test-http-request-dont-override-options to use common.mustCall as per issue #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mithunsasidharan mithunsasidharan changed the title from test : refactored test cases in test-http-request-dont-override-options to use countdown to test : refactored test-http-request-dont-override-options to use countdown Dec 3, 2017

@daxlab

daxlab approved these changes Dec 3, 2017

@apapirovski

This should be refactored to use common.mustCall instead of Countdown since it's supposed to only run 1 request anyway.

(I don't think the changes here are correct since the countdown never goes to 0.)

@mscdex mscdex added the http label Dec 3, 2017

@mithunsasidharan mithunsasidharan changed the title from test : refactored test-http-request-dont-override-options to use countdown to refactor : test-http-request-dont-override-options to use common.mustCall Dec 3, 2017

@mithunsasidharan

This comment has been minimized.

Show comment
Hide comment
@mithunsasidharan

mithunsasidharan Dec 3, 2017

Contributor

@apapirovski : Thanks for the feedback. I've updated the PR to include the recommended changes. Kindly review the PR now.

Contributor

mithunsasidharan commented Dec 3, 2017

@apapirovski : Thanks for the feedback. I've updated the PR to include the recommended changes. Kindly review the PR now.

@mithunsasidharan

This comment has been minimized.

Show comment
Hide comment
@mithunsasidharan

mithunsasidharan Dec 3, 2017

Contributor

@apapirovski : Thanks for the feedback. I've updated the PR addressing the review comments. Kindly review the PR. Thanks!

Contributor

mithunsasidharan commented Dec 3, 2017

@apapirovski : Thanks for the feedback. I've updated the PR addressing the review comments. Kindly review the PR. Thanks!

@apapirovski

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca approved these changes Dec 4, 2017

@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7

maclover7 Dec 6, 2017

Member

Landing...

Member

maclover7 commented Dec 6, 2017

Landing...

@maclover7 maclover7 self-assigned this Dec 6, 2017

@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7

maclover7 Dec 6, 2017

Member

Landed in 00c5b06

Member

maclover7 commented Dec 6, 2017

Landed in 00c5b06

@maclover7 maclover7 closed this Dec 6, 2017

maclover7 added a commit to maclover7/node that referenced this pull request Dec 6, 2017

test: update test-http-request-dont-override-options to use common.mu…
…stCall

PR-URL: nodejs#17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@addaleax addaleax removed the author ready label Dec 7, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: update test-http-request-dont-override-options to use common.mu…
…stCall

PR-URL: #17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: update test-http-request-dont-override-options to use common.mu…
…stCall

PR-URL: #17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test-http-request-dont-override-options to use common.mu…
…stCall

PR-URL: #17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test-http-request-dont-override-options to use common.mu…
…stCall

PR-URL: #17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test-http-request-dont-override-options to use common.mu…
…stCall

PR-URL: #17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: update test-http-request-dont-override-options to use common.mu…
…stCall

PR-URL: nodejs#17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: update test-http-request-dont-override-options to use common.mu…
…stCall

PR-URL: nodejs#17438
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment