New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update AUTHORS list #17452

Closed
wants to merge 1 commit into
base: master
from

Conversation

@targos
Member

targos commented Dec 4, 2017

64 new collaborators in two weeks!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@cjihrig

cjihrig approved these changes Dec 4, 2017

@danbev

danbev approved these changes Dec 4, 2017

@maclover7

Rubber stamp LGTM

@mhdawson

LGTM

I do see a number of cases were we don't have the full name of the person, but I assume the commit is the same.

Do we need to raise awareness among collaborators to make sure commit comments have the full name ?

@lpinca

lpinca approved these changes Dec 5, 2017

@jasnell

jasnell approved these changes Dec 5, 2017

@targos

This comment has been minimized.

Show comment
Hide comment
@targos

targos Dec 6, 2017

Member

@mhdawson

I do see a number of cases were we don't have the full name of the person, but I assume the commit is the same.

Yes

Do we need to raise awareness among collaborators to make sure commit comments have the full name ?

Maybe it's something that get-metadata could help with. For example print the author's name (as in the commit) next to the GitHub handle. It could even warn if it doesn't match the name in the GitHub profile.
/cc @nodejs/automation

Member

targos commented Dec 6, 2017

@mhdawson

I do see a number of cases were we don't have the full name of the person, but I assume the commit is the same.

Yes

Do we need to raise awareness among collaborators to make sure commit comments have the full name ?

Maybe it's something that get-metadata could help with. For example print the author's name (as in the commit) next to the GitHub handle. It could even warn if it doesn't match the name in the GitHub profile.
/cc @nodejs/automation

targos added a commit to targos/node that referenced this pull request Dec 6, 2017

doc: update AUTHORS list
PR-URL: nodejs#17452
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@targos

This comment has been minimized.

Show comment
Hide comment
@targos

targos Dec 6, 2017

Member

Landed in b52c23b with one more name.

Member

targos commented Dec 6, 2017

Landed in b52c23b with one more name.

@targos targos closed this Dec 6, 2017

@targos targos deleted the targos:update-authors branch Dec 6, 2017

@priyank-p

This comment has been minimized.

Show comment
Hide comment
@priyank-p

priyank-p Dec 6, 2017

Member

Maybe it's something that get-metadata could help with. For example print the author's name (as in the commit) next to the GitHub handle. It could even warn if it doesn't match the name in the GitHub profile.

@targos GitHub API v4 currently does not support getting name, but i added a feature request and it is in API V3 it should be added in about a week or so.

Member

priyank-p commented Dec 6, 2017

Maybe it's something that get-metadata could help with. For example print the author's name (as in the commit) next to the GitHub handle. It could even warn if it doesn't match the name in the GitHub profile.

@targos GitHub API v4 currently does not support getting name, but i added a feature request and it is in API V3 it should be added in about a week or so.

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: update AUTHORS list
PR-URL: #17452
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: update AUTHORS list
PR-URL: #17452
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: update AUTHORS list
PR-URL: #17452
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: update AUTHORS list
PR-URL: #17452
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: update AUTHORS list
PR-URL: #17452
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

doc: update AUTHORS list
PR-URL: nodejs#17452
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

doc: update AUTHORS list
PR-URL: nodejs#17452
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment