New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding Countdown to test-http-set-cookies test #17504

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@shilomangam
Contributor

shilomangam commented Dec 6, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Hi, first PR to NodeJS.
Worked on improving test by using Countdown:
#17169
Worked on file test-http-set-cookies.js

#goodnesssquad

@apapirovski

LGTM but some small changes required

Show outdated Hide outdated test/parallel/test-http-set-cookies.js Outdated
Show outdated Hide outdated test/parallel/test-http-set-cookies.js Outdated
Show outdated Hide outdated test/parallel/test-http-set-cookies.js Outdated
Show outdated Hide outdated test/parallel/test-http-set-cookies.js Outdated
Show outdated Hide outdated test/parallel/test-http-set-cookies.js Outdated
@apapirovski

LGTM

Show outdated Hide outdated test/parallel/test-http-set-cookies.js Outdated
@shilomangam

This comment has been minimized.

Show comment
Hide comment
@shilomangam

shilomangam Dec 6, 2017

Contributor

@apapirovski all of your comments were fixed, thanks!

Contributor

shilomangam commented Dec 6, 2017

@apapirovski all of your comments were fixed, thanks!

@shilomangam shilomangam changed the title from adding Countdown to test-http-set-cookies test #goodnessSquad to adding Countdown to test-http-set-cookies test Dec 6, 2017

@shilomangam shilomangam changed the title from adding Countdown to test-http-set-cookies test to test: adding Countdown to test-http-set-cookies test Dec 7, 2017

@lpinca

lpinca approved these changes Dec 7, 2017

@maclover7

This comment has been minimized.

Show comment
Hide comment
@Bamieh

Bamieh approved these changes Dec 8, 2017

@maclover7

This comment has been minimized.

Show comment
Hide comment

@apapirovski apapirovski referenced this pull request Dec 8, 2017

Closed

Update test-http-set-cookies to use Countdown #17550

3 of 3 tasks complete
@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Dec 8, 2017

Member

Landed in 6a089f9

Member

apapirovski commented Dec 8, 2017

Landed in 6a089f9

@apapirovski apapirovski closed this Dec 8, 2017

apapirovski added a commit that referenced this pull request Dec 8, 2017

test: use Countdown in test-http-set-cookies
PR-URL: #17504
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use Countdown in test-http-set-cookies
PR-URL: #17504
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use Countdown in test-http-set-cookies
PR-URL: #17504
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

@addaleax addaleax removed the author ready label Dec 13, 2017

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use Countdown in test-http-set-cookies
PR-URL: #17504
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use Countdown in test-http-set-cookies
PR-URL: #17504
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use Countdown in test-http-set-cookies
PR-URL: #17504
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: use Countdown in test-http-set-cookies
PR-URL: nodejs#17504
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: use Countdown in test-http-set-cookies
PR-URL: nodejs#17504
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment