New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding Countdown to test-http-incoming-pipelined-socket-destroy.js #17506

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@idandagan1
Contributor

idandagan1 commented Dec 6, 2017

Hi guys,
My first PR to NodeJS.
Added Countdown to test-http-incoming-pipelined-socket-destroy.js :
#17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

#goodnessSquad

@apapirovski

This comment has been minimized.

Show comment
Hide comment

@idandagan1 idandagan1 changed the title from adding Countdown to test-http-incoming-pipelined-socket-destroy.js #goodnessSquad to test: adding Countdown to test-http-incoming-pipelined-socket-destroy.js Dec 7, 2017

@lpinca

lpinca approved these changes Dec 7, 2017

apapirovski added a commit that referenced this pull request Dec 8, 2017

test: use Countdown in http test
PR-URL: #17506
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Dec 8, 2017

Member

CI: 20d6b8c

Thanks for the contribution @idandagan1! Congrats on becoming a Contributor! 🎉

Member

apapirovski commented Dec 8, 2017

CI: 20d6b8c

Thanks for the contribution @idandagan1! Congrats on becoming a Contributor! 🎉

@apapirovski apapirovski closed this Dec 8, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use Countdown in http test
PR-URL: #17506
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use Countdown in http test
PR-URL: #17506
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

@addaleax addaleax removed the author ready label Dec 13, 2017

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use Countdown in http test
PR-URL: #17506
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use Countdown in http test
PR-URL: #17506
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use Countdown in http test
PR-URL: #17506
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: use Countdown in http test
PR-URL: nodejs#17506
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: use Countdown in http test
PR-URL: nodejs#17506
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment