New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mention node-test-pull-request-lite job #17513

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@maclover7
Member

maclover7 commented Dec 7, 2017

Checklist
Affected core subsystem(s)

doc

@maclover7 maclover7 requested a review from Trott Dec 7, 2017

@apapirovski

LGTM

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt Dec 7, 2017

Member

LinuxONE includes doc building test, right? Does this job suffice for doc-only PRs?

Member

vsemozhetbyt commented Dec 7, 2017

LinuxONE includes doc building test, right? Does this job suffice for doc-only PRs?

@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7

maclover7 Dec 7, 2017

Member

LinuxONE includes doc building test, right? Does this job suffice for doc-only PRs?

@vsemozhetbyt Hmm, interesting question. My initial thought is that yes, it would be okay, although this is probably something that would need a separate issue opened for more discussion.

Member

maclover7 commented Dec 7, 2017

LinuxONE includes doc building test, right? Does this job suffice for doc-only PRs?

@vsemozhetbyt Hmm, interesting question. My initial thought is that yes, it would be okay, although this is probably something that would need a separate issue opened for more discussion.

@Trott

Trott approved these changes Dec 7, 2017

LGTM. Maybe instead of "quick fixes" say "trivial changes" or even "trivial doc-only changes"?

@cjihrig

cjihrig approved these changes Dec 7, 2017

@lpinca

lpinca approved these changes Dec 7, 2017

+1 to @Trott's suggestion.

@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7
Member

maclover7 commented Dec 7, 2017

updated @Trott @lpinca

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott
Member

Trott commented Dec 7, 2017

@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7

maclover7 Dec 8, 2017

Member

Landing...

Member

maclover7 commented Dec 8, 2017

Landing...

@maclover7 maclover7 self-assigned this Dec 8, 2017

@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7

maclover7 Dec 8, 2017

Member

Landed in de3a7db

Member

maclover7 commented Dec 8, 2017

Landed in de3a7db

maclover7 added a commit to maclover7/node that referenced this pull request Dec 8, 2017

doc: mention node-test-pull-request-lite job
PR-URL: nodejs#17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@maclover7 maclover7 closed this Dec 8, 2017

@maclover7 maclover7 deleted the maclover7:jm-add-job branch Dec 8, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: mention node-test-pull-request-lite job
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: mention node-test-pull-request-lite job
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

@addaleax addaleax removed the author ready label Dec 13, 2017

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: mention node-test-pull-request-lite job
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: mention node-test-pull-request-lite job
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: mention node-test-pull-request-lite job
PR-URL: #17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

doc: mention node-test-pull-request-lite job
PR-URL: nodejs#17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

doc: mention node-test-pull-request-lite job
PR-URL: nodejs#17513
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment