New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: more assorted fixes #17519

Closed
wants to merge 4 commits into
base: master
from

Conversation

@Trott
Member

Trott commented Dec 7, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@@ -130,7 +130,7 @@ can be fast-tracked and may be landed after a shorter delay:
* Changes that fix regressions.
When a pull request is deemed suitable to be fast-tracked, label it with
`fast-track`. The pull request can be landed once 2 or more collaborators
`fast-track`. The pull request can be landed once 2 or more Collaborators

This comment has been minimized.

@mithunsasidharan

mithunsasidharan Dec 7, 2017

Contributor

Shouldn't it be collaborators instead of Collaborators ? Its not the first word in a new line but part of the line right ?

@mithunsasidharan

mithunsasidharan Dec 7, 2017

Contributor

Shouldn't it be collaborators instead of Collaborators ? Its not the first word in a new line but part of the line right ?

This comment has been minimized.

@apapirovski

apapirovski Dec 7, 2017

Member

Collaborator is a title and it should be capitalized.

@apapirovski

apapirovski Dec 7, 2017

Member

Collaborator is a title and it should be capitalized.

This comment has been minimized.

@richardlau

richardlau Dec 7, 2017

Member

Should we be linting for capitalizing Collaborator(s) then?

@richardlau

richardlau Dec 7, 2017

Member

Should we be linting for capitalizing Collaborator(s) then?

This comment has been minimized.

@Trott

Trott Dec 7, 2017

Member

Shouldn't it be collaborators instead of Collaborators ?

A case could be made for lower case or capitalizing. While I would prefer lower case myself, I am far more concerned with consistency. Since we capitalize it multiple times elsewhere in this and other documents, capitalizing it here normalizes things without a lot of needless churn.

@Trott

Trott Dec 7, 2017

Member

Shouldn't it be collaborators instead of Collaborators ?

A case could be made for lower case or capitalizing. While I would prefer lower case myself, I am far more concerned with consistency. Since we capitalize it multiple times elsewhere in this and other documents, capitalizing it here normalizes things without a lot of needless churn.

Additionally, Current and LTS releases (not Nightlies) have the GPG
detached signature of SHASUMS256.txt available as SHASUMS256.txt.sig.
You can use `gpg` to verify that SHASUMS256.txt has not been tampered with.
Current and LTS releases (but not Nightlies) also have the GPG detached

This comment has been minimized.

@mithunsasidharan

mithunsasidharan Dec 7, 2017

Contributor

excluding Nightlies sounds more correct than but not Nightlies

@mithunsasidharan

mithunsasidharan Dec 7, 2017

Contributor

excluding Nightlies sounds more correct than but not Nightlies

This comment has been minimized.

@apapirovski

apapirovski Dec 7, 2017

Member

"but not Nightlies" sounds better to me because the two preceding items do not include (or in any way reference) Nightlies so "excluding" doesn't make sense.

@apapirovski

apapirovski Dec 7, 2017

Member

"but not Nightlies" sounds better to me because the two preceding items do not include (or in any way reference) Nightlies so "excluding" doesn't make sense.

Show outdated Hide outdated README.md Outdated

Trott added some commits Dec 7, 2017

doc: improve readability of COLLABORATOR_GUIDE.md
* convert run-on sentence to a bulleted list
* standardize capitalization in "Collaborators"
doc: improve readability of README.md
Use consistent typography and other minor changes to Verifying Binaries
section.
doc: improve text for Console constructor
Make text for Console constructor more precise.
doc: immprove inode text in fs.md
Rewrite and edit somewhat confusing paragraph about inodes and AIX in
fs.md.
@Trott

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca approved these changes Dec 8, 2017

Trott added a commit to Trott/io.js that referenced this pull request Dec 8, 2017

doc: improve readability of COLLABORATOR_GUIDE.md
* convert run-on sentence to a bulleted list
* standardize capitalization in "Collaborators"

PR-URL: nodejs#17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request Dec 8, 2017

doc: improve readability of README.md
Use consistent typography and other minor changes to Verifying Binaries
section.

PR-URL: nodejs#17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request Dec 8, 2017

doc: improve text for Console constructor
Make text for Console constructor more precise.

PR-URL: nodejs#17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request Dec 8, 2017

doc: immprove inode text in fs.md
Rewrite and edit somewhat confusing paragraph about inodes and AIX in
fs.md.

PR-URL: nodejs#17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Dec 8, 2017

Member

Landed in 5b4a5c8, af5cfaf, c3a9970, and 25385ef.

Member

Trott commented Dec 8, 2017

Landed in 5b4a5c8, af5cfaf, c3a9970, and 25385ef.

@Trott Trott closed this Dec 8, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: improve readability of COLLABORATOR_GUIDE.md
* convert run-on sentence to a bulleted list
* standardize capitalization in "Collaborators"

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: improve readability of README.md
Use consistent typography and other minor changes to Verifying Binaries
section.

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: improve text for Console constructor
Make text for Console constructor more precise.

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: immprove inode text in fs.md
Rewrite and edit somewhat confusing paragraph about inodes and AIX in
fs.md.

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: improve readability of COLLABORATOR_GUIDE.md
* convert run-on sentence to a bulleted list
* standardize capitalization in "Collaborators"

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: improve readability of README.md
Use consistent typography and other minor changes to Verifying Binaries
section.

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: improve text for Console constructor
Make text for Console constructor more precise.

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: immprove inode text in fs.md
Rewrite and edit somewhat confusing paragraph about inodes and AIX in
fs.md.

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Dec 20, 2017

Member

Backported 5b4a5c8 and c3a9970 to v6.x.

Member

gibfahn commented Dec 20, 2017

Backported 5b4a5c8 and c3a9970 to v6.x.

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: improve readability of COLLABORATOR_GUIDE.md
* convert run-on sentence to a bulleted list
* standardize capitalization in "Collaborators"

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: improve readability of README.md
Use consistent typography and other minor changes to Verifying Binaries
section.

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: improve text for Console constructor
Make text for Console constructor more precise.

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: immprove inode text in fs.md
Rewrite and edit somewhat confusing paragraph about inodes and AIX in
fs.md.

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: improve readability of COLLABORATOR_GUIDE.md
* convert run-on sentence to a bulleted list
* standardize capitalization in "Collaborators"

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: improve text for Console constructor
Make text for Console constructor more precise.

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: improve readability of COLLABORATOR_GUIDE.md
* convert run-on sentence to a bulleted list
* standardize capitalization in "Collaborators"

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: improve readability of README.md
Use consistent typography and other minor changes to Verifying Binaries
section.

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: improve text for Console constructor
Make text for Console constructor more precise.

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: immprove inode text in fs.md
Rewrite and edit somewhat confusing paragraph about inodes and AIX in
fs.md.

PR-URL: #17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

doc: improve readability of COLLABORATOR_GUIDE.md
* convert run-on sentence to a bulleted list
* standardize capitalization in "Collaborators"

PR-URL: nodejs#17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

doc: improve readability of README.md
Use consistent typography and other minor changes to Verifying Binaries
section.

PR-URL: nodejs#17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

doc: improve text for Console constructor
Make text for Console constructor more precise.

PR-URL: nodejs#17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

doc: immprove inode text in fs.md
Rewrite and edit somewhat confusing paragraph about inodes and AIX in
fs.md.

PR-URL: nodejs#17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

doc: improve readability of COLLABORATOR_GUIDE.md
* convert run-on sentence to a bulleted list
* standardize capitalization in "Collaborators"

PR-URL: nodejs#17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

doc: improve text for Console constructor
Make text for Console constructor more precise.

PR-URL: nodejs#17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

doc: immprove inode text in fs.md
Rewrite and edit somewhat confusing paragraph about inodes and AIX in
fs.md.

PR-URL: nodejs#17519
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment