New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: simplify and clarify FIPS text in BUILDING.md #17538

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@Trott
Member

Trott commented Dec 7, 2017

Fixes: #17536

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@Trott

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca approved these changes Dec 8, 2017

@mhdawson

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Dec 10, 2017

doc: simplify and clarify FIPS text in BUILDING.md
PR-URL: nodejs#17538
Fixes: nodejs#17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Dec 10, 2017

Member

Landed in 4426d75.

Member

Trott commented Dec 10, 2017

Landed in 4426d75.

@Trott Trott closed this Dec 10, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: simplify and clarify FIPS text in BUILDING.md
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: simplify and clarify FIPS text in BUILDING.md
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

@addaleax addaleax removed the author ready label Dec 13, 2017

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: simplify and clarify FIPS text in BUILDING.md
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: simplify and clarify FIPS text in BUILDING.md
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: simplify and clarify FIPS text in BUILDING.md
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: simplify and clarify FIPS text in BUILDING.md
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

doc: simplify and clarify FIPS text in BUILDING.md
PR-URL: nodejs#17538
Fixes: nodejs#17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

doc: simplify and clarify FIPS text in BUILDING.md
PR-URL: nodejs#17538
Fixes: nodejs#17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment