New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused include node_crypto_clienthello #17546

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@danbev
Member

danbev commented Dec 8, 2017

This commit removes the include of node.h which does not seem to be
used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

src: remove unused include node_crypto_clienthello
This commit removes the include of node.h which does not seem to be
used.
@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

This comment has been minimized.

Show comment
Hide comment
Member

danbev commented Dec 8, 2017

@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Dec 11, 2017

Member

Landed in 7bb2cc4.

Member

danbev commented Dec 11, 2017

Landed in 7bb2cc4.

@danbev danbev closed this Dec 11, 2017

@danbev danbev deleted the danbev:remove-unused-include-node_crypto_clienthello.h branch Dec 11, 2017

danbev added a commit that referenced this pull request Dec 11, 2017

src: remove unused include node_crypto_clienthello
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

src: remove unused include node_crypto_clienthello
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

src: remove unused include node_crypto_clienthello
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 20, 2017

src: remove unused include node_crypto_clienthello
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

src: remove unused include node_crypto_clienthello
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

src: remove unused include node_crypto_clienthello
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

gibfahn added a commit that referenced this pull request Dec 20, 2017

src: remove unused include node_crypto_clienthello
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

src: remove unused include node_crypto_clienthello
This commit removes the include of node.h which does not seem to be
used.

PR-URL: nodejs#17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

src: remove unused include node_crypto_clienthello
This commit removes the include of node.h which does not seem to be
used.

PR-URL: nodejs#17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment