Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-child-process-pass-fd on Fedora 24 #17598

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@Trott
Copy link
Member

commented Dec 11, 2017

test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

Fixes: #17589

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test child_process

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2017

Argh, just noticed something I should have looked at before: This problem does not happen on the Digital Ocean host, just the Rackspace host (which is probably provisioned with fewer resources). I will have to re-run the one of the stress tests.

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2017

Oh, neat-o, I guess...once the stress test fails, it then fails again and again and again. Stress test for master is red, so that at least confirms the problem.

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2017

Re-running stress test against this PR using Rackspace:

https://ci.nodejs.org/job/node-stress-single-test/1565/nodes=fedora24/

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2017

Stress test for this PR still failed with "Resource temporarily unavailable". More work to be done...

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2017

OK, more changes, trying again....

CI stress test: https://ci.nodejs.org/job/node-stress-single-test/1566/nodes=fedora24/console

test: fix flaky test-child-process-pass-fd
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

Fixes: #17589
@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2017

Stress test against this PR is looking very good: 9392 successes so far without a failure. I've rebased against master, squashed, written a better commit message and force pushed. Will wait for stress test to finish before running a full CI...removing in progress label.

@Trott Trott force-pushed the Trott:fixit-maybe branch from f9fbbb0 to 529f000 Dec 11, 2017

@Trott Trott changed the title wip fix flaky test-child-process-pass-fd test: fix flaky test-child-process-pass-fd on Fedora 24 Dec 11, 2017

@Trott Trott added the child_process label Dec 11, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 12, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 12, 2017

@gibfahn

This comment has been minimized.

Copy link
Member

commented Dec 12, 2017

LGTM as is, but might it be it worth adding a delay before trying to fork again?

@BridgeAR
Copy link
Member

left a comment

LGTM but I agree with @gibfahn that a delay would be good.

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2017

Landed in d64b0a8

@Trott Trott closed this Dec 13, 2017

Trott added a commit to Trott/io.js that referenced this pull request Dec 13, 2017

test: fix flaky test-child-process-pass-fd
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: nodejs#17598
Fixes: nodejs#17589
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

MylesBorins added a commit that referenced this pull request Jan 8, 2018

test: fix flaky test-child-process-pass-fd
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: #17598
Fixes: #17589
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

@MylesBorins MylesBorins referenced this pull request Jan 10, 2018

Merged

v9.4.0 proposal #18069

MylesBorins added a commit that referenced this pull request Jan 22, 2018

test: fix flaky test-child-process-pass-fd
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: #17598
Fixes: #17589
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

MylesBorins added a commit that referenced this pull request Jan 22, 2018

test: fix flaky test-child-process-pass-fd
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: #17598
Fixes: #17589
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

@MylesBorins MylesBorins referenced this pull request Jan 24, 2018

Merged

v6.13.0 proposal #18342

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: fix flaky test-child-process-pass-fd
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: nodejs#17598
Fixes: nodejs#17589
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: fix flaky test-child-process-pass-fd
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: nodejs#17598
Fixes: nodejs#17589
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

MylesBorins added a commit that referenced this pull request Feb 11, 2018

test: fix flaky test-child-process-pass-fd
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: #17598
Fixes: #17589
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

MylesBorins added a commit that referenced this pull request Feb 12, 2018

test: fix flaky test-child-process-pass-fd
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: #17598
Fixes: #17589
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

MylesBorins added a commit that referenced this pull request Feb 12, 2018

test: fix flaky test-child-process-pass-fd
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: #17598
Fixes: #17589
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

MylesBorins added a commit that referenced this pull request Feb 13, 2018

test: fix flaky test-child-process-pass-fd
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: #17598
Fixes: #17589
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.