New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.12.3 proposal #17776

Merged
merged 116 commits into from Jan 2, 2018

Conversation

Projects
None yet
@MylesBorins
Member

MylesBorins commented Dec 20, 2017

2018-01-02, Version 6.12.3 'Boron' (LTS), @MylesBorins

This LTS release comes with 115 commits. This includes 52 which are test related,
40 which are doc related, 12 which are build / tool related and 2 commits which updating a dependency.

Notable Changes

  • build:
    • configure can now be run from any directory (Gibson Fahnestock) #17321

Commits

  • [b1b975370f] - benchmark,path: remove unused variables (薛定谔的猫) #15789
  • [ac6f345f70] - build: allow running configure from any directory (Gibson Fahnestock) #17321
  • [017492eca2] - build: add serial commas to messages in configure script (Rich Trott) #17464
  • [ad9a8578ee] - build: fix test-v8 target (Michaël Zasso) #17269
  • [9ba35e859f] - build: remove empty VCLibrarianTool entry (Daniel Bevenius) #17191
  • [3d22e81d70] - build: minor corrections to configure descriptions (Daniel Bevenius) #17094
  • [92f41e553a] - build: allow enabling the --trace-maps flag in V8 (Evan Lucas) #14018
  • [b563908ff9] - crypto: use SetNull instead of Set (Daniel Bevenius) #17521
  • [b287b9e64b] - deps: V8: cherry-pick e8e9c07 from upstream (Ali Ijaz Sheikh)
  • [9804e7f3bb] - deps: V8: cherry-pick 9622696 from upstream (Ali Ijaz Sheikh)
  • [dcee5edef7] - doc: simplify and clarify FIPS text in BUILDING.md (Rich Trott) #17538
  • [f53b4df00e] - doc: 'constructor' implies use of new keyword (Cameron Moorehead) #17364
  • [67c526fbb8] - doc: improve text for Console constructor (Rich Trott) #17519
  • [013ef22ef8] - doc: improve readability of COLLABORATOR_GUIDE.md (Rich Trott) #17519
  • [ee52ce954a] - doc: mention node-test-pull-request-lite job (Jon Moss) #17513
  • [a44f0855b4] - doc: fix typo in repl.md (Rich Trott) #17502
  • [a15da3bf45] - doc: fix common typo involving one-time listeners (Rich Trott) #17502
  • [92d2c9aecb] - doc: update AUTHORS list (Michaël Zasso) #17452
  • [c24fafa881] - doc: edit module introduction (Rich Trott) #17463
  • [8ca12e2b6e] - doc: standardize preposition usage in fs.md (Rich Trott) #17463
  • [e8368a12d2] - doc: improve punctuation in fs.open() text (Rich Trott) #17463
  • [4d4337d3d3] - doc: use colon consistently in assert.md (Rich Trott) #17463
  • [0fa2f39457] - doc: improve checkServerIdentity docs (Hannes Magnusson) #17203
  • [35316dcd10] - doc: add guide to maintaining npm (Myles Borins) #16541
  • [90ee2ee943] - doc: clarify fast-track of reversions (Refael Ackermann) #17332
  • [3eab248a1f] - doc: Add link for ECMAScript 2015 (smatsu-hl) #17317
  • [c519287d3d] - doc: replace string with template string (Leko) #17316
  • [b2236a3804] - doc: replace function with arrow function in vm.md (narirou) #17307
  • [46dc2416b9] - doc: fix typo in api doc of url.format(urlObject) (pkovacs) #17295
  • [b13dab8b4d] - doc: add maclover7 to collaborators (Jon Moss) #17289
  • [ab91fe1686] - doc: update http URLs to https in README.md (Ronald Eddy Jr) #17264
  • [23f21a63d8] - doc: update http URLs to https in GOVERNANCE.md (Ronald Eddy Jr) #17262
  • [d692f4546c] - doc: update http URLs to https in CONTRIBUTING.md (Ronald Eddy Jr) #17261
  • [a0bd1c0b81] - doc: add SharedArrayBuffer to Buffer documentation (Thomas den Hollander) #15489
  • [5f522a18d9] - doc: use better terminology for build machines (Anna Henningsen) #17142
  • [3f39e47f6c] - doc: update mgol in AUTHORS.txt, add to .mailmap (Michał Gołębiowski-Owczarek) #17239
  • [80c6384985] - doc: update release table in V8 guide (Ali Ijaz Sheikh) #17136
  • [d4e9a2555d] - doc: add guybedford to collaborators (Guy Bedford) #17197
  • [e232e210f6] - doc: update AUTHORS list (Michaël Zasso) #16571
  • [ca76c336d1] - doc: normalize ToC indentation with heading levels in README (Rich Trott) #17106
  • [1815ca5066] - doc: add Contributing to Node.js to the README ToC (Rich Trott) #17106
  • [d8f66676e5] - doc: merge Working Groups with Contributing to Node.js in README (Rich Trott) #17106
  • [b064c731ff] - doc: remove IRC node-dev link from README (Rich Trott) #17106
  • [8cae573af1] - doc: add note about using cluster without networking (pimlie) #17031
  • [b16e6d29f1] - doc: explicitly document highWaterMark option (Sebastian Silbermann) #17049
  • [ccdf4b245a] - doc: reorganize collaborator guide (Joyee Cheung) #17056
  • [d44adf12a9] - doc: delete unused definition in README.md (Vse Mozhet Byt) #17108
  • [e03645dd6f] - doc: add Support section in README (Rich Trott) #16533
  • [0f94bb9aeb] - doc: add hashseed to collaborators (Yang Guo)
  • [5cd89c7817] - doc,win: clarify WSL support (João Reis) #17008
  • [93ca2f78c6] - meta: allow vague objections to be dismissed (James M Snell) #15233
  • [a12e16818f] - path: remove obsolete comment (Rich Trott) #17023
  • [2d74af0184] - src: remove unused include node_crypto_clienthello (Daniel Bevenius) #17546
  • [6792998f6a] - src: make base64.h self-contained (Daniel Bevenius) #17177
  • [84a8861b62] - src: remove unprofessional slang in assertions (Alexey Orlenko) #17166
  • [f11acca80c] - src: fix size of CounterSet (Witthawat Piwawatthanapanit) #16984
  • [a528d573ce] - test: remove hidden use of common.PORT in parallel tests (Rich Trott) #17466
  • [dbf5ddbc97] - test: refactor test-child-process-pass-fd (Rich Trott) #17596
  • [a50366fbf7] - test: improve assert messages in repl-reset-event (Adri Van Houdt) #16836
  • [bd4b97fe3d] - test: update test-http-should-keep-alive to use countdown (TomerOmri) #17505
  • [23edd08b00] - test: use Countdown in http test (idandagan1) #17506
  • [e9cacee677] - test: use Countdown in http-response-statuscode (Mandeep Singh) #17327
  • [68dabce07a] - test: use Countdown in test-http-set-cookies (Shilo Mangam) #17504
  • [d4d3f50f9d] - test: Use common.mustCall in http test (sreepurnajasti) #17487
  • [6e7ace2dcf] - test: replace fs.accessSync with fs.existsSync (Leko) #17446
  • [3cf8f98c3e] - test: add common.crashOnUnhandledRejection() (IHsuan) #17247
  • [d1d547d2ab] - test: update test-http-request-dont-override-options to use common.mustCall (Mithun Sasidharan) #17438
  • [f9adf51744] - test: use common.mustCall in test-http-malformed-request (Mithun Sasidharan) #17439
  • [8fc196905d] - test: use Countdown in http test (Mithun Sasidharan) #17436
  • [47e5fd940e] - test: update test-http-response-multiheaders to use countdown (hmammedzadeh) #17419
  • [660e6dea89] - test: update test-http-upgrade-client to use countdown (Mithun Sasidharan) #17339
  • [8f997c0117] - test: update test-http-status-reason-invalid-chars to use countdown (Mithun Sasidharan) #17342
  • [42454a5c34] - test: refactored test-http-allow-req-after-204-res to countdown (Mithun Sasidharan) #17211
  • [3ee4c1e149] - test: update test/parallel/test-http-pipe-fs.js to use countdown (ChungNgoops) #17346
  • [8908cd6cc1] - test: refactored test-http-response-splitting to use countdown (Mithun Sasidharan) #17348
  • [4f3a165827] - test: replace function with ES6 arrow function (Junichi Kajiwara) #17306
  • [3a0cb8fcae] - test: refactored http test to use countdown (Mithun Sasidharan) #17241
  • [f3c1158f57] - test: Update test-http-parser-free to use countdown timer (Mandeep Singh) #17322
  • [956198f30d] - test: Update test-http-client-agent to use countdown timer (Mandeep Singh) #17325
  • [35cc1b3fcc] - test: fix isNAN->Number.isNAN (yuza yuko) #17309
  • [32ebcf7fd0] - test: make use of Number.isNaN to test-readfloat.js (Hiromu Yoshiwara) #17310
  • [1cd4076a4e] - test: replace function with arrow function (spring_raining) #17312
  • [0ef4f78ae0] - test: replace function with arrow function (Hiroaki KARASAWA) #17308
  • [c0c366634d] - test: use arrow function (koooge) #17318
  • [8098a6ed0e] - test: use Number.isNaN() (MURAKAMI Masahiko) #17319
  • [bdbcdebb65] - test: add test of stream Transform (Yoshiya Hinosawa) #17303
  • [75ad37c854] - test: use common.crashOnUnhandledRejection (Kcin1993) #17235
  • [b63f51aa7f] - test: use common.crashOnUnhandledRejection (zhengyuanjie) #17215
  • [797e33b602] - test: use common.crashOnUnhandledRejection (Jason Chung) #17233
  • [699659e5df] - test: use common.crashOnUnhandledRejection() (sorarize@gmail.com) #17232
  • [89f1b6c041] - test: add common.crashOnHandleRejection (jackyen) #17225
  • [7cbdeefc7e] - test: remove unlink function which is needless (buji) #17119
  • [7c57ab76ec] - test: dont need to remove nonexistent directory (buji) #17119
  • [71671df00e] - test: fix linting error (James M Snell) #17251
  • [6620e761d7] - test: use crashOnUnhandledRejection (Roth Peng) #17226
  • [d4a5499360] - test: use common.crashOnUnhandledRejection (esbb48) #17218
  • [353e66f823] - test: use arrow function instead of bind (Lance Ball) #17202
  • [289ebb19b5] - test: use crashOnUnhandledRejection (Chiahao Lin) #17219
  • [e7ca894114] - test: use common.crashOnUnhandledRejection (Whien) #17214
  • [0963c75c8e] - test: clean up inappropriate language (Gus Caplan) #17170
  • [5d488ee13f] - test: wrap callback in common.mustCall (suman-mitra) #17173
  • [fd36b27949] - test: remove unused parameter in test-next-tick-error-spin.js (Francois KY) #17185
  • [43e4669467] - test: remove unused parameter (Fran Herrero) #17193
  • [4eb1b58481] - test: remove unused variable (Guillaume Flandre) #17187
  • [39cd0a8abc] - test: utilize common.mustCall() on child exit (sreepurnajasti) #16996
  • [fe2188620d] - test: use arrow functions instead of bind (Tobias Nießen) #17070
  • [92daa2d2d3] - test: make REPL test pass in coverage mode (Anna Henningsen) #17082
  • [c18a450e9d] - test: add coverage to tty module (cjihrig) #16959
  • [ad0d878772] - tools: simplify buffer-constructor rule (cjihrig) #17572
  • [5383422672] - tools: simplify prefer-assert-methods rule (cjihrig) #17572
  • [3e70ee84fb] - tools: simplify prefer-common-mustnotcall rule (cjihrig) #17572
  • [afd4d9e348] - tools: add Boxstarter script (Bartosz Sosnowski) #17046
  • [466e94a6c1] - tools: avoid using process.cwd in tools/lint-js (Tobias Nießen) #17121
  • [dcf7646725] - tools: fail tests if malformed status file (Rich Trott) #16703
  • [d176073511] - tty: refactor exports (cjihrig) #16959

cjihrig and others added some commits Nov 12, 2017

tty: refactor exports
This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
test: add coverage to tty module
PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
build: allow enabling the --trace-maps flag in V8
This can be useful for tracing map creation.

PR-URL: #14018
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
meta: allow vague objections to be dismissed
Explicitly allow vague objections to change requests to
be dismissed if requests for clarification go unanswered

PR-URL: #15233
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
deps: V8: cherry-pick 9622696 from upstream
Original commit message:
  [profiler] sampled allocations should be marked as independent

  Sampling heap profiler keeps weak references. These should be marked
  independent so that the weak callback can be dispatched on new space
  collections.

  BUG= v8:4959
  LOG=N
  R=ulan@chromium.org

  Review-Url: https://codereview.chromium.org/1945193002
  Cr-Commit-Position: refs/heads/master@{#36012}

Ref: https://bugs.chromium.org/p/v8/issues/detail?id=4959
Ref: v8/v8@9622696
deps: V8: cherry-pick e8e9c07 from upstream
Original commit message:
  Make sure the heap is in consistent state when calling allocation observers.

  The observer might want to lookup something in the heap, e.g. code objects
  it has in the call stack.

  BUG=v8:4959
  LOG=N

  Review-Url: https://codereview.chromium.org/1948893002
  Cr-Commit-Position: refs/heads/master@{#36027}

Ref: https://bugs.chromium.org/p/v8/issues/detail?id=4959
Ref: v8/v8@e8e9c07
doc: add hashseed to collaborators
PR-URL: #16863
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
path: remove obsolete comment
Remove commented-out code that is leftover from a refactoring.

PR-URL: #17023
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
test: make REPL test pass in coverage mode
Make a REPL tab completion test pass in coverage mode by using
`Uin` as the common prefix of all `Uint*Array` globals instead
of `co` which could be a prefix for `console` and `coverage`,
so it doesn't expand the way it's expected to in coverage mode.

PR-URL: #17082
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
doc,win: clarify WSL support
Fixes: #13471
PR-URL: #17008
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
doc: add Support section in README
Add a Support section, borrowing heavily from wp-cli project.

Move stuff about contributing to Node.js to the bottom as vastly more
users are interested in using Node.js and getting help with Node.js than
contributing to Node.js. Information still belongs, just not at the top.
(Many people will know to look in CONTRIBUTING.md anyway.)

PR-URL: #16533
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
doc: delete unused definition in README.md
PR-URL: #17108
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
tools: fail tests if malformed status file
PR-URL: #16703
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
doc: reorganize collaborator guide
* Add sections about first time contributions, code reviews
  and seeking consensus, waiting for approvals, testing and CI
* Move paragraphs to more suitable sections
* Update table of contents
* Document the fast-tracking process

PR-URL: #17056
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
test: use arrow functions instead of bind
PR-URL: #17070
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
doc: explicitly document highWaterMark option
PR-URL: #17049
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
doc: add note about using cluster without networking
Although the primary use-case for the cluster module is networking, the
module provides a generic master/worker interface that could also be
used if you dont use networking at all. Currently the docs are a bit
ambiguous about this as only the primary use-case is ever mentioned,
this remark should clarify that the cluster module can also be used
without disadvantages if you dont use networking.

PR-URL: #17031
Refs: nodejs/help#970
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
test: utilize common.mustCall() on child exit
PR-URL: #16996
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
src: fix size of CounterSet
PR-URL: #16984
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
build: minor corrections to configure descriptions
PR-URL: #17094
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
doc: remove IRC node-dev link from README
The IRC link is mentioned in CONTRIBUTING.md which is linked immediately
above. We should encourage people to read that doc before hoping on the
IRC channel.

PR-URL: #17106
Ref: #16533 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
doc: merge Working Groups with Contributing to Node.js in README
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
doc: add Contributing to Node.js to the README ToC
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
doc: normalize ToC indentation with heading levels in README
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
tools: avoid using process.cwd in tools/lint-js
The first occurrence of path.join() can easily be replaced with
path.resolve().
The second occurrence should be unnecessary as ESLint will resolve the
path internally, and the old check probably did not work as intended
anyway.

PR-URL: #17121
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
doc: update AUTHORS list
PR-URL: #16571
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
test: remove unused variable
PR-URL: #17187
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
test: remove unused parameter
PR-URL: #17193
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
src: remove unprofessional slang in assertions
Convert `CHECK(0 && "wtf?")` (sic) assertions to more suitable
`UNREACHABLE()` macro invocations in `node_zlib.cc`.

PR-URL: #17166
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
test: remove unused parameter in test-next-tick-error-spin.js
PR-URL: #17185
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott and others added some commits Dec 7, 2017

doc: simplify and clarify FIPS text in BUILDING.md
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
src: remove unused include node_crypto_clienthello
This commit removes the include of node.h which does not seem to be
used.

PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
tools: simplify prefer-common-mustnotcall rule
PR-URL: #17572
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
tools: simplify prefer-assert-methods rule
PR-URL: #17572
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
tools: simplify buffer-constructor rule
PR-URL: #17572
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
test: refactor test-child-process-pass-fd
Add a comment explaining the test (especailly why it forks 80 processes.
Use destructuring and an arrow function callback.

PR-URL: #17596
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
benchmark,path: remove unused variables
PR-URL: #15789
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
test: remove hidden use of common.PORT in parallel tests
common.hasMultiLocalhost() uses common.PORT under the hood. This is
problematic in parallel tests because another test using port 0 to
get an arbitrary open port may end up getting common.PORT before the
test using common.PORT gets it.

Therefore, change common.PORT to port 0 in common.hasMultiLocalhost().

Backport-PR-URL: #17771
PR-URL: #17466
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Dec 20, 2017

2018-01-02, Version 6.12.3 'Boron' (LTS)
Notable Changes:

Coming Soon

PR-URL: #17776
@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Dec 21, 2017

Cannot locally reproduce failures

Running CI one more time: https://ci.nodejs.org/job/node-test-pull-request/12253/

@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Dec 22, 2017

CI was green this time

@maclover7 it doesn't look like this updated the CI results

@MylesBorins

This comment has been minimized.

2018-01-02, Version 6.12.3 'Boron' (LTS)
Notable Changes:

* build:
  - configure can now be run from any directory (Gibson Fahnestock)
    #17321

PR-URL: #17776

@MylesBorins MylesBorins requested review from refack and removed request for refack Jan 2, 2018

@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Jan 2, 2018

CI and CITGM look good. Only failures are unrelated

@MylesBorins MylesBorins merged commit d5fbd25 into v6.x Jan 2, 2018

5 checks passed

node-test-commit tests passed
Details
node-test-commit-aix tests passed
Details
node-test-commit-linux tests passed
Details
node-test-commit-windows-fanned tests passed
Details
node-test-linux-linked-fips20 tests passed
Details

MylesBorins added a commit that referenced this pull request Jan 2, 2018

MylesBorins added a commit that referenced this pull request Jan 2, 2018

2018-01-02, Version 6.12.3 'Boron' (LTS)
Notable Changes:

* build:
  - configure can now be run from any directory (Gibson Fahnestock)
    #17321

PR-URL: #17776

MylesBorins added a commit to MylesBorins/nodejs.org that referenced this pull request Jan 2, 2018

@gibfahn gibfahn deleted the v6.12.3-proposal branch Jan 3, 2018

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

2018-01-02, Version 6.12.3 'Boron' (LTS)
Notable Changes:

* build:
  - configure can now be run from any directory (Gibson Fahnestock)
    nodejs#17321

PR-URL: nodejs#17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

2018-01-02, Version 6.12.3 'Boron' (LTS)
Notable Changes:

* build:
  - configure can now be run from any directory (Gibson Fahnestock)
    nodejs#17321

PR-URL: nodejs#17776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment