Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-pipe-unref #17950

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@apapirovski
Copy link
Member

commented Jan 2, 2018

This test doesn't need to use an arbitrary setTimeout, it should just end naturally (if working as intended) or timeout as per default for all tests.

Fixes: #16875

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@cjihrig

cjihrig approved these changes Jan 2, 2018

@apapirovski

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2018

@lpinca

lpinca approved these changes Jan 2, 2018

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Jan 5, 2018

Landed in c043b82

@BridgeAR BridgeAR closed this Jan 5, 2018

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 5, 2018

test: fix flaky test-pipe-unref
PR-URL: nodejs#17950
Fixes: nodejs#16875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@apapirovski apapirovski deleted the apapirovski:test-fix-pipe-unref branch Jan 5, 2018

MylesBorins added a commit that referenced this pull request Jan 8, 2018

test: fix flaky test-pipe-unref
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Jan 9, 2018

test: fix flaky test-pipe-unref
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Jan 9, 2018

test: fix flaky test-pipe-unref
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request Jan 10, 2018

Merged

v9.4.0 proposal #18069

@TimothyGu TimothyGu removed the author ready label Jan 13, 2018

MylesBorins added a commit that referenced this pull request Jan 24, 2018

test: fix flaky test-pipe-unref
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Jan 24, 2018

test: fix flaky test-pipe-unref
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request Jan 24, 2018

Merged

v6.13.0 proposal #18342

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: fix flaky test-pipe-unref
PR-URL: nodejs#17950
Fixes: nodejs#16875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: fix flaky test-pipe-unref
PR-URL: nodejs#17950
Fixes: nodejs#16875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Feb 11, 2018

test: fix flaky test-pipe-unref
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Feb 12, 2018

test: fix flaky test-pipe-unref
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Feb 12, 2018

test: fix flaky test-pipe-unref
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Feb 13, 2018

test: fix flaky test-pipe-unref
PR-URL: #17950
Fixes: #16875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.