Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-http-pipeline-flood #17955

Closed

Conversation

Projects
None yet
4 participants
@apapirovski
Copy link
Member

commented Jan 2, 2018

This fixes one of the issues with this test (the repeated timeout, for which there's no real reason to validate that it only occurs exactly once). Haven't been able to reproduce the other one so perhaps there was a bug that was fixed in the meantime or something. Not sure.

Refs: #16317

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@apapirovski apapirovski added the test label Jan 2, 2018

@apapirovski

This comment has been minimized.

@apapirovski apapirovski force-pushed the apapirovski:fix-test-http-pipeline-flood branch 2 times, most recently from 888a02f to a41fba7 Jan 3, 2018

@apapirovski apapirovski force-pushed the apapirovski:fix-test-http-pipeline-flood branch from a41fba7 to 0ea2754 Jan 3, 2018

@apapirovski

This comment has been minimized.

Copy link
Member Author

commented Jan 5, 2018

ping @nodejs/http @nodejs/http2 — this test fails fairly regularly so it would be nice to get it fixed. The timeout here is irrelevant to the test and is only used to stop it so having it called multiple times is completely harmless.

@jasnell

jasnell approved these changes Jan 5, 2018

@apapirovski

This comment has been minimized.

Copy link
Member Author

commented Jan 6, 2018

Landed in b396c4d

@apapirovski apapirovski closed this Jan 6, 2018

@apapirovski apapirovski deleted the apapirovski:fix-test-http-pipeline-flood branch Jan 6, 2018

apapirovski added a commit that referenced this pull request Jan 6, 2018

test: fix flaky test-http-pipeline-flood
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Jan 8, 2018

test: fix flaky test-http-pipeline-flood
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Jan 9, 2018

test: fix flaky test-http-pipeline-flood
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Jan 9, 2018

test: fix flaky test-http-pipeline-flood
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jan 10, 2018

Merged

v9.4.0 proposal #18069

@TimothyGu TimothyGu removed the author ready label Jan 13, 2018

MylesBorins added a commit that referenced this pull request Jan 24, 2018

test: fix flaky test-http-pipeline-flood
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Jan 24, 2018

test: fix flaky test-http-pipeline-flood
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jan 24, 2018

Merged

v6.13.0 proposal #18342

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: fix flaky test-http-pipeline-flood
PR-URL: nodejs#17955
Refs: nodejs#16317
Reviewed-By: James M Snell <jasnell@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: fix flaky test-http-pipeline-flood
PR-URL: nodejs#17955
Refs: nodejs#16317
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 11, 2018

test: fix flaky test-http-pipeline-flood
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 12, 2018

test: fix flaky test-http-pipeline-flood
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 12, 2018

test: fix flaky test-http-pipeline-flood
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 13, 2018

test: fix flaky test-http-pipeline-flood
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.