New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix crypto test case to use correct encoding #17956

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@tniessen
Member

tniessen commented Jan 2, 2018

The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
test: fix crypto test case to use correct encoding
The callback would have errored out anyway due to the incorrect
encoding, and that error is not the point of this test case.
@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Jan 2, 2018

Contributor

The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case.

Can the error message check be improved so that the test only passes with the correct error?

Contributor

cjihrig commented Jan 2, 2018

The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case.

Can the error message check be improved so that the test only passes with the correct error?

@cjihrig

cjihrig approved these changes Jan 2, 2018

@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Jan 2, 2018

Member

The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case.

Can the error message check be improved so that the test only passes with the correct error?

It already does not pass, but there is no reason to intentionally use an incorrect encoding here. If we really want to pass an invalid encoding, we should at least add a comment. To me, it was not obvious why the test failed with the message [ERR_ASSERTION]: Cannot change encoding when authentication passed.

Member

tniessen commented Jan 2, 2018

The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case.

Can the error message check be improved so that the test only passes with the correct error?

It already does not pass, but there is no reason to intentionally use an incorrect encoding here. If we really want to pass an invalid encoding, we should at least add a comment. To me, it was not obvious why the test failed with the message [ERR_ASSERTION]: Cannot change encoding when authentication passed.

@tniessen

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell approved these changes Jan 3, 2018

@tniessen

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Jan 5, 2018

Member

Landed in 5160dd0

Member

BridgeAR commented Jan 5, 2018

Landed in 5160dd0

@BridgeAR BridgeAR closed this Jan 5, 2018

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 5, 2018

test: fix crypto test case to use correct encoding
The callback would have errored out anyway due to the incorrect
encoding, and that error is not the point of this test case.

PR-URL: nodejs#17956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Jan 8, 2018

test: fix crypto test case to use correct encoding
The callback would have errored out anyway due to the incorrect
encoding, and that error is not the point of this test case.

PR-URL: #17956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Jan 9, 2018

test: fix crypto test case to use correct encoding
The callback would have errored out anyway due to the incorrect
encoding, and that error is not the point of this test case.

PR-URL: #17956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Jan 9, 2018

test: fix crypto test case to use correct encoding
The callback would have errored out anyway due to the incorrect
encoding, and that error is not the point of this test case.

PR-URL: #17956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request Jan 10, 2018

Merged

v9.4.0 proposal #18069

@TimothyGu TimothyGu removed the author ready label Jan 13, 2018

MylesBorins added a commit that referenced this pull request Jan 24, 2018

test: fix crypto test case to use correct encoding
The callback would have errored out anyway due to the incorrect
encoding, and that error is not the point of this test case.

PR-URL: #17956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Jan 24, 2018

test: fix crypto test case to use correct encoding
The callback would have errored out anyway due to the incorrect
encoding, and that error is not the point of this test case.

PR-URL: #17956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request Jan 24, 2018

Merged

v6.13.0 proposal #18342

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: fix crypto test case to use correct encoding
The callback would have errored out anyway due to the incorrect
encoding, and that error is not the point of this test case.

PR-URL: nodejs#17956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: fix crypto test case to use correct encoding
The callback would have errored out anyway due to the incorrect
encoding, and that error is not the point of this test case.

PR-URL: nodejs#17956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Feb 11, 2018

test: fix crypto test case to use correct encoding
The callback would have errored out anyway due to the incorrect
encoding, and that error is not the point of this test case.

PR-URL: #17956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Feb 12, 2018

test: fix crypto test case to use correct encoding
The callback would have errored out anyway due to the incorrect
encoding, and that error is not the point of this test case.

PR-URL: #17956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Feb 12, 2018

test: fix crypto test case to use correct encoding
The callback would have errored out anyway due to the incorrect
encoding, and that error is not the point of this test case.

PR-URL: #17956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Feb 13, 2018

test: fix crypto test case to use correct encoding
The callback would have errored out anyway due to the incorrect
encoding, and that error is not the point of this test case.

PR-URL: #17956
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment