Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace assert.throws with expectsError #17997

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@sreepurnajasti
Copy link
Contributor

commented Jan 5, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@lpinca

lpinca approved these changes Jan 5, 2018

@jasnell

jasnell approved these changes Jan 5, 2018

@BridgeAR

This comment has been minimized.

jasnell added a commit that referenced this pull request Jan 9, 2018

test: replace assert.throws with expectsError
PR-URL: #17997
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@jasnell

This comment has been minimized.

Copy link
Member

commented Jan 9, 2018

Landed in 7969811

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

This change does not work on v9.x, could someone please backport

@sreepurnajasti sreepurnajasti deleted the sreepurnajasti:expect-error branch Jan 10, 2018

@TimothyGu TimothyGu removed the author ready label Jan 13, 2018

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: replace assert.throws with expectsError
PR-URL: nodejs#17997
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: replace assert.throws with expectsError
PR-URL: nodejs#17997
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

@MylesBorins This seems to work now, I’m removing the backport-requested-v9.x label. I don’t suppose you remember how this failed? If it’s not a merge conflict, it might be helpful to have the errors you are seeing posted for context.

addaleax added a commit to addaleax/node that referenced this pull request Feb 27, 2018

test: replace assert.throws with expectsError
PR-URL: nodejs#17997
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@addaleax addaleax referenced this pull request Feb 27, 2018

Closed

v9.7.0 proposal #19040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.