Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: simplify sentences that use "considered" #18095

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
9 participants
@Trott
Copy link
Member

commented Jan 11, 2018

Change many instances of "x is considered to be y" to "x is y".

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

doc: simplify sentences that use "considered"
Change many instances of "x is considered to be y" to "x is y".
@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2018

@danbev

danbev approved these changes Jan 11, 2018

@lpinca

lpinca approved these changes Jan 11, 2018

@@ -622,7 +622,7 @@ Once a socket is assigned to this request and is connected
added: v0.5.9
-->

* `timeout` {number} Milliseconds before a request is considered to be timed out.
* `timeout` {number} Milliseconds before a request times out.

This comment has been minimized.

Copy link
@lpinca

lpinca Jan 11, 2018

Member

Unrelated but I think this description is a bit misleading. This timeout expires only after x millisecond of inactivity on the socket. It's possible that a data chunk resets the timeout right before it expires without completing the request.

I'll open a separate PR if I remember :)

This comment has been minimized.

Copy link
@Trott

Trott Jan 11, 2018

Author Member

@lpinca Perhaps you or I can add a squash-able commit here to change it to Milliseconds of inactivity before a request times out.?

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2018

Landed in c6bee70.

@Trott Trott closed this Jan 18, 2018

Trott added a commit to Trott/io.js that referenced this pull request Jan 18, 2018

doc: simplify sentences that use "considered"
Change many instances of "x is considered to be y" to "x is y".

PR-URL: nodejs#18095
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

evanlucas added a commit that referenced this pull request Jan 30, 2018

doc: simplify sentences that use "considered"
Change many instances of "x is considered to be y" to "x is y".

PR-URL: #18095
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

doc: simplify sentences that use "considered"
Change many instances of "x is considered to be y" to "x is y".

PR-URL: nodejs#18095
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

doc: simplify sentences that use "considered"
Change many instances of "x is considered to be y" to "x is y".

PR-URL: nodejs#18095
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 27, 2018

doc: simplify sentences that use "considered"
Change many instances of "x is considered to be y" to "x is y".

PR-URL: #18095
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 27, 2018

doc: simplify sentences that use "considered"
Change many instances of "x is considered to be y" to "x is y".

PR-URL: #18095
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

This was referenced Feb 27, 2018

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

doc: simplify sentences that use "considered"
Change many instances of "x is considered to be y" to "x is y".

PR-URL: nodejs#18095
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.