Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
async_hooks: rename PromiseWrap.parentId #18633
referenced this pull request
Feb 8, 2018
@ofrobots please always trigger a CI (mini in this case) after creating a PR :-)
That aside: I also think it would be better to have a breaking change in this case.
I went looking for known users of
The following did come up with a use; but I don't think it is a real use.
Based on this, I think it is reasonable to go ahead and make a breaking change.