Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add process.debugPort to doc/api/process.md #18716

Closed
wants to merge 4 commits into from

Conversation

@flickz
Copy link
Contributor

commented Feb 11, 2018

Ref: #18639

Added process.debugPort to process api doc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc


A port number for the debugger to listen to.

This comment has been minimized.

Copy link
@cjihrig

cjihrig Feb 11, 2018

Contributor

Maybe rephrase as "The port used by Node's debugger when it is enabled." or something similar.

This comment has been minimized.

Copy link
@flickz

flickz Feb 11, 2018

Author Contributor

Alright

@daynin

daynin approved these changes Feb 11, 2018


The port used by Node's debugger when enabled.

This comment has been minimized.

Copy link
@BridgeAR

BridgeAR Feb 12, 2018

Member

It is actually called Node.js so it should be called Node.js's.

This comment has been minimized.

Copy link
@flickz

flickz Feb 12, 2018

Author Contributor

Noted

@lpinca

lpinca approved these changes Feb 13, 2018

@targos

This comment has been minimized.

The port used by Node.js's debugger when enabled.

```js
process.debugPort = 5858;

This comment has been minimized.

Copy link
@BridgeAR

BridgeAR Feb 17, 2018

Member

The linter complains about the indentation. Please do not use any spaces here :-)

@BridgeAR BridgeAR removed the author ready label Feb 17, 2018

@flickz

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2018

@BridgeAR Resolved

@mmarchini

This comment has been minimized.

@mmarchini

This comment has been minimized.

Copy link
Member

commented Feb 26, 2018

Landed in 65ca369 😄

@mmarchini mmarchini closed this Feb 26, 2018

mmarchini added a commit that referenced this pull request Feb 26, 2018

doc: add process.debugPort to doc/api/process.md
Fixes: #18639

PR-URL: #18716
Refs: #18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

addaleax added a commit to addaleax/node that referenced this pull request Feb 26, 2018

doc: add process.debugPort to doc/api/process.md
Fixes: nodejs#18639

PR-URL: nodejs#18716
Refs: nodejs#18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

addaleax added a commit that referenced this pull request Feb 26, 2018

doc: add process.debugPort to doc/api/process.md
Fixes: #18639

PR-URL: #18716
Refs: #18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@addaleax addaleax referenced this pull request Feb 27, 2018

Closed

v9.7.0 proposal #19040

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

doc: add process.debugPort to doc/api/process.md
Fixes: nodejs#18639

PR-URL: nodejs#18716
Refs: nodejs#18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

jasnell added a commit to jasnell/node that referenced this pull request Aug 17, 2018

doc: add process.debugPort to doc/api/process.md
Fixes: nodejs#18639

PR-URL: nodejs#18716
Refs: nodejs#18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MylesBorins added a commit that referenced this pull request Sep 6, 2018

doc: add process.debugPort to doc/api/process.md
Fixes: #18639

Backport-PR-URL: #22380
PR-URL: #18716
Refs: #18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@MylesBorins MylesBorins referenced this pull request Sep 6, 2018

Merged

v8.12.0 proposal #21593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.