Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix/add link to Android info #19004

Closed

Conversation

Projects
None yet
8 participants
@vsemozhetbyt
Copy link
Contributor

commented Feb 26, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, build

We have two notes in API docs about Android support: the first has no links, the second links to the table of supported OSs where Android is not mentioned which may be confusing.

This PR makes both notes link to dedicated Android part of BUILDING.md.

doc: fix/add link to Android info
We have two notes in API docs about Android support:
the first has no links, the second links to the table of supported OSs
where Android is not mentioned which may be confusing.

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:doc-android-build-links branch from 26d9bb4 to 7863e99 Feb 26, 2018

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2018

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2018

Landed in fcebb16

vsemozhetbyt added a commit that referenced this pull request Feb 26, 2018

doc: fix/add link to Android info
We have two notes in API docs about Android support:
the first has no links, the second links to the table of supported OSs
where Android is not mentioned which may be confusing.

This PR makes both notes link to dedicated Android part of BUILDING.md.

PR-URL: #19004
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-android-build-links branch Feb 26, 2018

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Mar 6, 2018

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

vsemozhetbyt added a commit to vsemozhetbyt/node that referenced this pull request Mar 6, 2018

doc: fix/add link to Android info
We have two notes in API docs about Android support:
the first has no links, the second links to the table of supported OSs
where Android is not mentioned which may be confusing.

This PR makes both notes link to dedicated Android part of BUILDING.md.

PR-URL: nodejs#19004
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

@vsemozhetbyt vsemozhetbyt referenced this pull request Mar 6, 2018

Closed

[v9.x backport] doc: fix/add link to Android info #19183

2 of 3 tasks complete
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2018

v9 backport PR: #19183

vsemozhetbyt added a commit to vsemozhetbyt/node that referenced this pull request Mar 7, 2018

doc: fix/add link to Android info
We have two notes in API docs about Android support:
the first has no links, the second links to the table of supported OSs
where Android is not mentioned which may be confusing.

This PR makes both notes link to dedicated Android part of BUILDING.md.

PR-URL: nodejs#19004
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

MylesBorins added a commit that referenced this pull request Mar 7, 2018

doc: fix/add link to Android info
We have two notes in API docs about Android support:
the first has no links, the second links to the table of supported OSs
where Android is not mentioned which may be confusing.

This PR makes both notes link to dedicated Android part of BUILDING.md.

Backport-PR-URL: #19183
PR-URL: #19004
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

@MylesBorins MylesBorins referenced this pull request Mar 7, 2018

Merged

v9.8.0 proposal #19181

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

doc: fix/add link to Android info
We have two notes in API docs about Android support:
the first has no links, the second links to the table of supported OSs
where Android is not mentioned which may be confusing.

This PR makes both notes link to dedicated Android part of BUILDING.md.

PR-URL: nodejs#19004
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Aug 17, 2018

Does not land cleanly in 8.x. If this needs to be backported, a backport PR will be necessary.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2018

v8 backport PR: #22386

MylesBorins added a commit that referenced this pull request Sep 6, 2018

doc: fix/add link to Android info
We have two notes in API docs about Android support:
the first has no links, the second links to the table of supported OSs
where Android is not mentioned which may be confusing.

This PR makes both notes link to dedicated Android part of BUILDING.md.

Backport-PR-URL: #22386
PR-URL: #19004
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

@MylesBorins MylesBorins referenced this pull request Sep 6, 2018

Merged

v8.12.0 proposal #21593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.