Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix minor issues in async_hooks.md #19313

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@Trott
Copy link
Member

Trott commented Mar 13, 2018

  • easily -> easy
  • was -> is
  • add a missing comma
Checklist
doc: fix minor issues in async_hooks.md
* easily -> easy
* was -> is
* add a missing comma
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Mar 13, 2018

@Trott Trott added the author ready label Mar 13, 2018

@lpinca

lpinca approved these changes Mar 13, 2018

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Mar 15, 2018

Landed in e5e0f9f

@Trott Trott closed this Mar 15, 2018

Trott added a commit to Trott/io.js that referenced this pull request Mar 15, 2018

doc: fix minor issues in async_hooks.md
* easily -> easy
* was -> is
* add a missing comma

PR-URL: nodejs#19313
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos added a commit that referenced this pull request Mar 17, 2018

doc: fix minor issues in async_hooks.md
* easily -> easy
* was -> is
* add a missing comma

PR-URL: #19313
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@targos targos referenced this pull request Mar 18, 2018

Merged

v9.9.0 proposal #19428

MylesBorins added a commit that referenced this pull request Mar 20, 2018

doc: fix minor issues in async_hooks.md
* easily -> easy
* was -> is
* add a missing comma

PR-URL: #19313
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

FallenRiteMonk added a commit to FallenRiteMonk/node that referenced this pull request Mar 23, 2018

doc: fix minor issues in async_hooks.md
* easily -> easy
* was -> is
* add a missing comma

PR-URL: nodejs#19313
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

BethGriggs added a commit that referenced this pull request Oct 17, 2018

doc: fix minor issues in async_hooks.md
* easily -> easy
* was -> is
* add a missing comma

PR-URL: #19313
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@BethGriggs BethGriggs referenced this pull request Oct 30, 2018

Merged

v8.13.0 proposal #23974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.