Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove use of "random port" regarding dgram send #19620

Closed
wants to merge 1 commit into from

Conversation

@tlhunter
Copy link
Contributor

commented Mar 26, 2018

Checklist

I removed the use of "random port" when referring to sending messages with dgram. Specifically in the examples the port isn't random, it is a hand-picked port which stays the same. Referring to it as a random port is confusing because in the listening methods the phrase "random port" has a special meaning, i.e. providing no port and letting the OS pick a random port.

@Trott
Trott approved these changes Mar 26, 2018
@Trott

This comment has been minimized.

Copy link
Member

commented Mar 26, 2018

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2018

@tlhunter Can you check your local and GitHub settings:

https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#setting-up-your-local-environment

It seems the commit has not proper attribution.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2018

@Trott, @addaleax
In such cases, we can git commit --amend --author="Thomas Hunter II <me@thomashunter.name>" before pushing, right?

@addaleax

This comment has been minimized.

Copy link
Member

commented Mar 26, 2018

@vsemozhetbyt I would wait for confirmation from the author – the commit does have proper attribution as far as I can tell (name + email present and the email seems valid). That usually means that it’s easier for the author to add that email to github, if they do want that.

@tlhunter

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2018

@vsemozhetbyt @addaleax Whoops! That email should now be properly associated to my GH account.

vsemozhetbyt added a commit that referenced this pull request Mar 27, 2018
PR-URL: #19620
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2018

Landed in cdfe47b

Thank you!

@tlhunter tlhunter deleted the tlhunter:docs-dgram-clarification branch Mar 27, 2018
targos added a commit that referenced this pull request Mar 27, 2018
PR-URL: #19620
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs added a commit that referenced this pull request Dec 4, 2018
PR-URL: #19620
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs referenced this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.