Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove "if provided" for optional arguments #19690

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Mar 30, 2018

Remove "if provided" when discussing arguments that are explicitly
indicated to be optional and have default values.

Checklist
@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2018

@lpinca
lpinca approved these changes Mar 30, 2018

@lpinca lpinca added the author ready label Mar 30, 2018

@trivikr trivikr added the fast-track label Mar 30, 2018

@Leko
Leko approved these changes Mar 30, 2018
@targos
targos approved these changes Mar 30, 2018
@jasnell
jasnell approved these changes Apr 1, 2018
doc: remove "if provided" for optional arguments
Remove "if provided" when discussing arguments that are explicitly
indicated to be optional and have default values.

@Trott Trott force-pushed the Trott:if-provided branch from fb2f7a2 to 603e4b4 Apr 2, 2018

@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2018

@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2018

Landed in 6de1a12

@Trott Trott closed this Apr 2, 2018

Trott added a commit to Trott/io.js that referenced this pull request Apr 2, 2018
doc: remove "if provided" for optional arguments
Remove "if provided" when discussing arguments that are explicitly
indicated to be optional and have default values.

PR-URL: nodejs#19690
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Apr 2, 2018
doc: remove "if provided" for optional arguments
Remove "if provided" when discussing arguments that are explicitly
indicated to be optional and have default values.

PR-URL: #19690
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos referenced this pull request Apr 4, 2018
BethGriggs added a commit that referenced this pull request Dec 4, 2018
doc: remove "if provided" for optional arguments
Remove "if provided" when discussing arguments that are explicitly
indicated to be optional and have default values.

PR-URL: #19690
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs referenced this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.