Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: verify multiple init via well-known symbol #19875

Closed

Conversation

Projects
None yet
5 participants
@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Apr 8, 2018

Re-require() the addon after clearing its cache to ensure that it is
re-initialized via the well-known symbol.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
test: verify multiple init via well-known symbol
Re-`require()` the addon after clearing its cache to ensure that it is
re-initialized via the well-known symbol.
@Trott

Trott approved these changes Apr 8, 2018

@cjihrig

cjihrig approved these changes Apr 8, 2018

@BridgeAR

This comment has been minimized.

@gabrielschulhof

This comment has been minimized.

Copy link
Contributor Author

gabrielschulhof commented Apr 9, 2018

Landed in 244af7a.

gabrielschulhof added a commit that referenced this pull request Apr 9, 2018

test: verify multiple init via well-known symbol
Re-`require()` the addon after clearing its cache to ensure that it is
re-initialized via the well-known symbol.

PR-URL: #19875
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@gabrielschulhof gabrielschulhof deleted the gabrielschulhof:multiple-require branch Apr 9, 2018

targos added a commit that referenced this pull request Apr 12, 2018

test: verify multiple init via well-known symbol
Re-`require()` the addon after clearing its cache to ensure that it is
re-initialized via the well-known symbol.

PR-URL: #19875
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.