Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing quotes in default string values #19894

Closed
wants to merge 1 commit into from
Closed

doc: add missing quotes in default string values #19894

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 9, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 9, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 9, 2018 •
edited

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/460/

@lpinca
Copy link
Member

lpinca commented Apr 9, 2018

I wonder if the same should be done for string events but it probably does not worth the effort.

@vsemozhetbyt
Copy link
Contributor Author

@lpinca I will try to check fragments that can be detected by a pattern.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2018
@vsemozhetbyt
Copy link
Contributor Author

Landed in 321c178

vsemozhetbyt added a commit that referenced this pull request Apr 9, 2018
@vsemozhetbyt
doc: add missing quotes in default string values
321c178 
PR-URL: #19894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@vsemozhetbyt vsemozhetbyt deleted the doc-types-wrap-str-in-quotes branch April 9, 2018 14:03
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 10, 2018 •
edited

@lpinca
I've done my best)

targos pushed a commit that referenced this pull request Apr 12, 2018
@vsemozhetbyt @targos
doc: add missing quotes in default string values
f56f14d 
PR-URL: #19894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vsemozhetbyt @lpinca @cjihrig @nodejs-github-bot