Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing backticks in n-api.md #20390

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@vsemozhetbyt
Copy link
Contributor

commented Apr 28, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Codify types, variable names, and code fragments checking patterns I've managed to think of.

Some nits were also fixed in passing (add missing periods, remove extra line breaks etc).

@nodejs/documentation, @nodejs/n-api, sorry for the big diff (it is easily reviewable though): it seems we are a bit (understandably) careless in this big and complicated doc.

doc: add missing backticks in n-api.md
Codify types, variable names, and code fragments
checking patterns I've managed to think of.

Some nits were also fixed in passing
(add missing periods, remove extra line breaks etc).
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2018

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2018

(Not sure if this can be fast-tracked with more than 200 lines diff, but as the changes are nits-only,
please, add 👍 here if you do approve fast-tracking after the review.)

@BridgeAR BridgeAR added the fast-track label Apr 29, 2018

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2018

Landed in 8809f8b

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-napi-codify branch Apr 29, 2018

vsemozhetbyt added a commit that referenced this pull request Apr 29, 2018

doc: add missing backticks in n-api.md
Codify types, variable names, and code fragments
checking patterns I've managed to think of.

Some nits were also fixed in passing
(add missing periods, remove extra line breaks etc).

PR-URL: #20390
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

isurusiri added a commit to isurusiri/node that referenced this pull request Apr 30, 2018

doc: add missing backticks in n-api.md
Codify types, variable names, and code fragments
checking patterns I've managed to think of.

Some nits were also fixed in passing
(add missing periods, remove extra line breaks etc).

PR-URL: nodejs#20390
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request May 4, 2018

doc: add missing backticks in n-api.md
Codify types, variable names, and code fragments
checking patterns I've managed to think of.

Some nits were also fixed in passing
(add missing periods, remove extra line breaks etc).

PR-URL: #20390
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request May 8, 2018

Merged

v10.1.0 proposal #20606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.