Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: reduce require calls in http2/core #20422

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@danbev
Copy link
Member

commented Apr 30, 2018

This commit removes unnecesary requires of http and internal/util in
http2/core.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
http2: reduce require calls in http2/core
This commit removes unnecesary requires of http and internal/util in
http2/core.js
@danbev

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2018

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Apr 30, 2018

-0 as this is mainly churn out of my perspective.

@lpinca

lpinca approved these changes Apr 30, 2018

@trivikr

trivikr approved these changes May 1, 2018

@danbev

This comment has been minimized.

Copy link
Member Author

commented May 2, 2018

Landed in 557f570.

@danbev danbev closed this May 2, 2018

@danbev danbev deleted the danbev:http2_core_requires branch May 2, 2018

danbev added a commit to danbev/node that referenced this pull request May 2, 2018

http2: reduce require calls in http2/core
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

MylesBorins added a commit that referenced this pull request May 4, 2018

http2: reduce require calls in http2/core
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: #20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@MylesBorins MylesBorins referenced this pull request May 8, 2018

Merged

v10.1.0 proposal #20606

kjin added a commit to kjin/node that referenced this pull request Aug 23, 2018

http2: reduce require calls in http2/core
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Sep 11, 2018

http2: reduce require calls in http2/core
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Sep 13, 2018

http2: reduce require calls in http2/core
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Sep 15, 2018

http2: reduce require calls in http2/core
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Sep 17, 2018

http2: reduce require calls in http2/core
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Sep 19, 2018

http2: reduce require calls in http2/core
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Oct 16, 2018

http2: reduce require calls in http2/core
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

BethGriggs added a commit to BethGriggs/node that referenced this pull request Oct 16, 2018

http2: reduce require calls in http2/core
This commit removes unnecesary requires of http and internal/util in
http2/core.js

Backport-PR-URL: nodejs#22850
PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

BethGriggs added a commit that referenced this pull request Oct 17, 2018

http2: reduce require calls in http2/core
This commit removes unnecesary requires of http and internal/util in
http2/core.js

Backport-PR-URL: #22850
PR-URL: #20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@BethGriggs BethGriggs referenced this pull request Oct 30, 2018

Merged

v8.13.0 proposal #23974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.