Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
readline: fix freeze if `keypress` event throws #2107
The issue is described here: #1968
Basically, I see are two good ways to deal with it:
Since everything in readline is synchronous now, adding
This PR fixes a particular bug. But avoiding throwing in repl might still be a good idea. So PR #1968 might still make sense, but as a refactor, not a bugfix (I'll let someone else to review it though).
// cc: @monsanto