Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add fs.watchFile() + worker.terminate() test #21179

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Jun 6, 2018

Refs: #21093 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax requested a review from apapirovski Jun 6, 2018

@hiroppy
hiroppy approved these changes Jun 7, 2018
@cjihrig
cjihrig approved these changes Jun 7, 2018
test/parallel/test-worker-fs-stat-watcher.js Outdated Show resolved Hide resolved
@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2018

Getting related CI failures like https://ci.nodejs.org/job/node-test-commit-linuxone/1994/nodes=rhel72-s390x/testReport/junit/(root)/test/parallel_test_worker_fs_stat_watcher/:

out/Release/node[29153]: ../src/node_worker.cc:307:virtual node::worker::Worker::~Worker(): Assertion `(uv_loop_close(&loop_)) == (0)' failed.
 1: node::Abort() [out/Release/node]
 2: 0x15084c4 [out/Release/node]
 3: node::worker::Worker::~Worker() [out/Release/node]
 4: node::Environment::RunCleanup() [out/Release/node]

I’ll look into it.

@addaleax addaleax added the blocked label Jun 7, 2018

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2018

Ok, so, this seems to expose a libuv bug, and I see no way of hacking around that. Guess this PR will have to wait for now.

libuv/libuv#1869

@trivikr
trivikr approved these changes Jun 8, 2018

@addaleax addaleax force-pushed the addaleax:worker-fs-watch-file branch from a03e9bf to 3f00235 Mar 18, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

With libuv 1.27.0 (#26707) merged, this should now finally be ready!

CI: https://ci.nodejs.org/job/node-test-pull-request/21643/

@addaleax addaleax added author ready and removed blocked labels Mar 18, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

Landed in d398e89 🎉

@addaleax addaleax closed this Mar 18, 2019

@addaleax addaleax deleted the addaleax:worker-fs-watch-file branch Mar 18, 2019

addaleax added a commit that referenced this pull request Mar 18, 2019
test: add fs.watchFile() + worker.terminate() test
Refs: #21093 (comment)

PR-URL: #21179
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
test: add fs.watchFile() + worker.terminate() test
Refs: nodejs#21093 (comment)

PR-URL: nodejs#21179
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
test: add fs.watchFile() + worker.terminate() test
Refs: nodejs#21093 (comment)

PR-URL: nodejs#21179
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
test: add fs.watchFile() + worker.terminate() test
Refs: nodejs#21093 (comment)

PR-URL: nodejs#21179
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Mar 27, 2019
test: add fs.watchFile() + worker.terminate() test
Refs: #21093 (comment)

PR-URL: #21179
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos referenced this pull request Mar 27, 2019
BethGriggs added a commit that referenced this pull request Apr 17, 2019
test: add fs.watchFile() + worker.terminate() test
Refs: #21093 (comment)

PR-URL: #21179
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
@addaleax

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

@BethGriggs I think this is causing failures in v10.x-staging because it depends on #26707… I think either this has to be removed or the libuv update has to be included in v10.x as well

MylesBorins added a commit that referenced this pull request May 16, 2019
test: add fs.watchFile() + worker.terminate() test
Refs: #21093 (comment)

PR-URL: #21179
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.