Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: don't bind to 0.0.0.0 by default (v6.x) #21376

Closed
wants to merge 4 commits into from

Conversation

@bnoordhuis
Copy link
Member

commented Jun 17, 2018

Change the bind address from 0.0.0.0 to 127.0.0.1 and start respecting
the address part of --inspect=<address>:<port> so that the bind
address can be overridden by the user.

Fixes: #21349

Trott and others added 4 commits Jun 8, 2018
tools,gyp: fix regex for version matching
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.

PR-URL: #21216
Refs: nodejs/node-gyp@293092c
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
build: fix configure script for double-digits
Compare versions using tuples instead of strings so that it is
future-proofed against versions that contain a number that is more than
one digit.

Backport-PR-URL: #21301
PR-URL: #21183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
tools: update tooling to work with new macOS CLI …
Using High Sierra and `xcode-select --install` without installing full
Xcode, our build tooling breaks due to faulty regular expressions.

Update the `configure` script in our project root directory to handle
multi-digit version numbers.

`tools/gyp` and `deps/npm/node_modules/node-gyp` still need to be
updated for a complete fix.

PR-URL: #21173
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
inspector: don't bind to 0.0.0.0 by default
Change the bind address from 0.0.0.0 to 127.0.0.1 and start respecting
the address part of `--inspect=<address>:<port>` so that the bind
address can be overridden by the user.

Fixes: #21349
@bnoordhuis

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2018

Linter failure is infrastructural:

./node tools/lint-js.js -j 2 -f tap -o test-eslint.tap \
	benchmark doc lib test tools
gmake: ./node: Command not found
@richardlau

This comment has been minimized.

Copy link
Member

commented Jun 17, 2018

Build PR for v6.x linter: nodejs/build#1349

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jun 25, 2018

@nodejs/release @nodejs/lts do we want to do a 6.x release for this?

@richardlau

This comment has been minimized.

Copy link
Member

commented Jun 27, 2018

do we want to do a 6.x release for this?

In 6.x the V8 inspector is an experimental feature, so I would say no to doing a release specifically for this. I would not be opposed to including it in a release if other critical fixes are found to warrant a release.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 1, 2018

@lirantal

This comment has been minimized.

Copy link
Member

commented Aug 1, 2018

That's a welcomed change 👍
I believe we also need to update the documentation too?

@rvagg

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

FYI this is queued up for inclusion in v6.14.4 as per https://nodejs.org/en/blog/vulnerability/august-2018-security-releases/

@rvagg rvagg force-pushed the nodejs:v6.x-staging branch from 14b46d0 to e9a76de Aug 16, 2018

@maclover7

This comment has been minimized.

Copy link
Member

commented Aug 16, 2018

Landed in v6.14.4 by @rvagg in 08a150f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.