Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 2.13.0 #2152

Closed
wants to merge 3 commits into from

Conversation

@othiym23
Copy link
Contributor

commented Jul 10, 2015

Now includes more npm ping, and also all the https://github.com/npm/npm/releases/tag/v2.13.0.

r: @Fishrock123
r: @chrisdickinson

(note for @Fishrock123: are there any additional patches we should be cherry-picking? I thought I saw some additional node-gyp changes in a PR a week or so ago, but I noticed that npm@2.12.1 only had the same two cherry-picked patches.)

cjihrig and others added 3 commits Feb 27, 2015
deps: make node-gyp work with io.js
Every npm version bump requires a few patches to be floated on
node-gyp for io.js compatibility. These patches are found in
03d1992,
5de334c, and
da730c7. This commit squashes
them into a single commit.

PR-URL: #990
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
win,node-gyp: enable delay-load hook by default
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: #1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@brendanashworth brendanashworth added the npm label Jul 10, 2015

@rvagg

This comment has been minimized.

Copy link
Member

commented Jul 10, 2015

@othiym23 that patch lives on next only so still business as usual on master

@Fishrock123

This comment has been minimized.

Copy link
Member

commented Jul 11, 2015

@thefourtheye due to how npm releases are done, review comments left here are pretty fruitless unless there is a critical bug. :) (and note that npm releases are a week behind because current release are pre-releases.)

@thefourtheye

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2015

@Fishrock123 I just realized after leaving the comments :D I removed them immediately. Looks like our deps updates need just a green CI run if applicable.

@Fishrock123

This comment has been minimized.

Copy link
Member

commented Jul 12, 2015

Looks like our deps updates need just a green CI run if applicable.

The regular CI doesn't and can't test npm. There is a special CI job for it, but it hasn't been used and doesn't work very well for a variety of reasons, including that npm tests don't work so well on windows, and also the stuff that #1984 now attempts to patch over.

@thefourtheye

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2015

@Fishrock123 Hmmm, would smoke testing project be a good place to include npm test?

@Fishrock123

This comment has been minimized.

Copy link
Member

commented Jul 12, 2015

@thefourtheye I don't necessarily think it has to be, or should be, even if it could be.

othiym23 added a commit that referenced this pull request Jul 16, 2015
deps: upgrade to npm 2.13.0
PR-URL: #2152
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123

This comment has been minimized.

Copy link
Member

commented Jul 16, 2015

Thanks, landed in 6c3aabf...cff7300 ... sorry for the delay!

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Jul 17, 2015
2015-07-17 io.js v2.4.0 Release
Notable changes

* src: Added a new `--track-heap-objects` flag to track heap object
allocations for heap snapshots (Bradley Meck)
nodejs#2135.
* readline: Fixed a freeze that affected the repl if the keypress event
handler threw (Alex Kocharin) nodejs#2107.
* npm: Upgraded to v2.13.0, release notes can be found in
https://github.com/npm/npm/releases/tag/v2.13.0 (Forrest L Norvell)
nodejs#2152.

PR-URL: nodejs#2189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.