Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix some links #21619

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@vsemozhetbyt
Copy link
Contributor

commented Jul 1, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2018

cc @addaleax re worker_threads.md fixes.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott

Trott approved these changes Jul 1, 2018

Copy link
Member

left a comment

Rubber stamp LGTM

@cjihrig

cjihrig approved these changes Jul 1, 2018

@hiroppy

hiroppy approved these changes Jul 2, 2018

@lpinca

lpinca approved these changes Jul 2, 2018

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2018

Landed in 2ae4524
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-fix-links branch Jul 2, 2018

vsemozhetbyt added a commit that referenced this pull request Jul 2, 2018

doc: fix some links
PR-URL: #21619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos added a commit that referenced this pull request Jul 3, 2018

doc: fix some links
PR-URL: #21619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@targos targos referenced this pull request Jul 3, 2018

Merged

v10.6.0 proposal #21629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.