New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test of fs.promises write for non-string buffers #21708

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@Shagamii
Copy link
Contributor

Shagamii commented Jul 8, 2018

  • To increase fs promises coverage, add test of fs.promises write for non-string buffers.
  • Fix comment of fs.promises write that was "read", despite "write".
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@fhinkel

fhinkel approved these changes Jul 8, 2018

@Leko

Leko approved these changes Jul 8, 2018

@lpinca

lpinca approved these changes Jul 9, 2018

@addaleax

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jul 13, 2018

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jul 15, 2018

Landed in c596eb2, a8ec288 🎉

@addaleax addaleax closed this Jul 15, 2018

addaleax added a commit that referenced this pull request Jul 15, 2018

test: add test of fs.promises write for non-string buffers
PR-URL: #21708
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

addaleax added a commit that referenced this pull request Jul 15, 2018

test: fix comment of fs.promises write
PR-URL: #21708
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos added a commit that referenced this pull request Jul 16, 2018

test: add test of fs.promises write for non-string buffers
PR-URL: #21708
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos added a commit that referenced this pull request Jul 16, 2018

test: fix comment of fs.promises write
PR-URL: #21708
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@targos targos referenced this pull request Jul 17, 2018

Merged

v10.7.0 proposal #21851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment